Sound is missing from RoundToggleButton.

[pixelzoom]

Discovered while working on alt input for momentary toggle buttons in #796.

In 1df861f, @samreid added sound to RectangularToggleButton, but did not add sound to RoundToggleButton. I see no reason why the sound should be different because a button is rectangular vs round, so labeling this as a bug.

[pixelzoom]

It looks like sun buttons are in the (bad) habit of duplicating sound code in the round vs rectangular versions of buttons. For example, RectangularPushButton and RoundPushButton both contain these duplicated lines of code:

type SelfOptions = {
  soundPlayer?: TSoundPlayer;
};

      soundPlayer: sharedSoundPlayers.get( 'pushButton' ),

    // sound generation
    const playSound = () => { options.soundPlayer.play(); };
    pushButtonModel.produceSoundEmitter.addListener( playSound );

      pushButtonModel.produceSoundEmitter.removeListener( playSound );

Unfortunately, I don't see any easy option but to follow this same pattern of duplication (for now) with RectangularToggleButton and RoundToggleButton.

[jessegreenberg]

Sorry @pixelzoom I am confused, I see sounds in RoundToggleButton here:

sun/js/buttons/RoundToggleButton.ts

Lines 47 to 48 in 99ac78e

	valueOffSoundPlayer: sharedSoundPlayers.get( 'toggleOff' ),
	valueOnSoundPlayer: sharedSoundPlayers.get( 'toggleOn' ),

Is there a sim or place where this isn't working?

[pixelzoom]

Hmm.... My bad. Not sure what I was looking at. I was probably confusing this RectangularStickyToggleButton, which I see @jessegreenberg fixed up in b8622cb on 9/26. Sorry for the bother, closing.