Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstrument pressListener from UI Components that have a better alternative view-side emitter. #1680

Closed
zepumph opened this issue Jan 10, 2025 · 2 comments
Closed

Uninstrument pressListener from UI Components that have a better alternative view-side emitter. #1680

zepumph opened this issue Jan 10, 2025 · 2 comments
Assignees
@zepumph

Comments

@zepumph
Copy link
Member

zepumph commented Jan 10, 2025

From #1676, we found that much of pressListener instances can be uninstrumented. I'll take a look.
@zepumph zepumph self-assigned this Jan 10, 2025
@zepumph zepumph mentioned this issue Jan 10, 2025
Closed
3 tasks
@zepumph
Copy link
Member Author

zepumph commented Jan 10, 2025

After the above changes, there are only 114 instances of "pressListener" in all API files for all PhET-iO sims (not just stable ones). Good job! These cases seem right to me. Some could be improved by using FireListener, but that goes beyond the scope of this issue.

@samreid @arouinfar please note. I'm not concerned here since we really don't use pressListener instances (even most spots in interaction-dashboard were able to use more appropriate things for UI components).

zepumph referenced this issue in phetsims/joist Jan 10, 2025
@zepumph
opt out of most PressListener instrumentations (there are better ways),
92314e0
zepumph referenced this issue in phetsims/sun Jan 10, 2025
@zepumph
opt out of most PressListener instrumentations (there are better ways),
6f9a44c
zepumph referenced this issue Jan 10, 2025
@zepumph
opt out of most PressListener instrumentations (there are better ways),
b3d353c
@zepumph zepumph closed this as completed Jan 10, 2025
@zepumph zepumph mentioned this issue Jan 10, 2025
Closed
8 tasks
@zepumph
Copy link
Member Author

zepumph commented Jan 10, 2025

Just noting, this took Buoyancy from 4100 elements down to 3600. Amaze!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph