-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voicing needs listeners to fire on disabled Nodes #1220
Comments
It would probably be good to discuss exactly in what cases we'd generally want that type of input, to determine how to best handle it. |
Thus far, this type of voicing would occur when you focus on the element (which is already supported), as well as when you try to select it (like on |
This is partially what I'm curious about. Most clicks activate on the "up", I don't know how we'd handle touch-snag, and we'd truly want to be able to support all of the custom input listeners. |
The The |
This is specifically something that was considered when @zepumph and I were discussing approaches. We considered a flag on listeners where they would still have events fired even when inputDisabled, AND the listeners then would need to be very aware of when they were called when inputDisabled. That sounds like a reasonable approach to me, however it might be good to brainstorm and meet about this, since this effectively changes our general needs from what I was aware of. |
We will need this for the "lock ratio" checkbox in Ratio and Proportion. Marking for meeting to initially discuss with @jessegreenberg. We can pull in @jonathanolson with what our findings are, and more brainstorming. |
We also need it for the Range combo box in Ratio and Proportion. |
@jessegreenberg, is this similar to the issue about voicing invisible Nodes? Should it be part of that design while we are working in scenery? Let's talk at our meeting tomorrow. |
@terracoda, can you note here whether or not you feel like this is blocking the publication of Ratio and Proportion with voicing. If so, we can get some of @jonathanolson's time on the books (likely for early Q2) to get this supported. |
@terracoda had a fun idea about this today. Let's refocus this issue into our actual case, which is that disabled nodes that support voicing would look like a mouse-only reading block (not available with keyboard), and it would say the name response and "unavailble" (mimicing aria-disabled in NVDA). Basically we could somehow wrap the node in a reading block, only when disabled though. We wouldn't want any content in the PDOM (text content or button). I'll see how it could go! Then we talked about design differences between ReadingBlocks, and disabled content. For example, would we always want them to both have black hover highlight. I think this may be enough to try it out. @terracoda also mentioned that it would be good to talk this through with @jessegreenberg, because they may have spoken about this before. |
@jessegreenberg and I discussed this a bit further today, and the conclusion we came to really was that this needs to be a scenery-level change. We have 3 paths forward:
|
Last Friday, @terracoda and I brainstormed what (2) may look like above, and we came to the conclusion that it would be more trouble than it was worth. The primary reason is because we would need to make sure to support the parent with keyboard interaction with voicing while also keeping the actual element focusable with keyboard (but disabled) for description. From this, as well as further discussion during the quarterly team planning meeting today, we aren't going to devote time to this at least until Q3 2022. Makring on hold. |
From a voicing meeting today with @jessegreenberg and others, we discussed the need for listeners to fire on disabled components. Like if you click on a disabled checkbox, it may voice "show force values, disabled." Currently inputEnabled (which enabled runs on) won't let this happen. It would be good to discuss this with @jonathanolson to see what could be done. Do you have any ideas?
The text was updated successfully, but these errors were encountered: