Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can resetNotInProgressProperty be removed from QuadrilateralModel? #459

Open
jbphet opened this issue Jul 12, 2024 · 0 comments
Open

Can resetNotInProgressProperty be removed from QuadrilateralModel? #459

jbphet opened this issue Jul 12, 2024 · 0 comments
Assignees

Comments

@jbphet
Copy link
Contributor

jbphet commented Jul 12, 2024

There are some changes being made to the sound library, and one is that sounds are muted/disabled by default during a reset. While integrating this change into the sims, I found the following in QaudrilateralModel:

  // Whether a reset is currently in progress. Added for sound. If the model is actively resetting, SoundManagers
  // are disabled so we don't play sounds for transient model states. Tracks when the reset is NOT in progress
  // because that makes it most convenient to pass to SoundGenerator enableControlProperties.
  public readonly resetNotInProgressProperty: TProperty<boolean>;

I started working to remove it, but this Property is wired through a lot of places in the sim, and it seemed to me like some of the usages were not sound related, so I started getting nervous. I removed it from the one place I could find where it was being passed through to a sound generator, but I thought it best to leave any further modifications to someone who knows the sim better than I. I regression tested my changes, and the sounds seemed to be working fine.

@jessegreenberg - please have a look and see if this can be removed or perhaps renamed. At the very least, the comment should be updated. I'll add a TODO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants