You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some changes being made to the sound library, and one is that sounds are muted/disabled by default during a reset. While integrating this change into the sims, I found the following in QaudrilateralModel:
// Whether a reset is currently in progress. Added for sound. If the model is actively resetting, SoundManagers// are disabled so we don't play sounds for transient model states. Tracks when the reset is NOT in progress// because that makes it most convenient to pass to SoundGenerator enableControlProperties.publicreadonlyresetNotInProgressProperty: TProperty<boolean>;
I started working to remove it, but this Property is wired through a lot of places in the sim, and it seemed to me like some of the usages were not sound related, so I started getting nervous. I removed it from the one place I could find where it was being passed through to a sound generator, but I thought it best to leave any further modifications to someone who knows the sim better than I. I regression tested my changes, and the sounds seemed to be working fine.
@jessegreenberg - please have a look and see if this can be removed or perhaps renamed. At the very least, the comment should be updated. I'll add a TODO.
The text was updated successfully, but these errors were encountered:
There are some changes being made to the sound library, and one is that sounds are muted/disabled by default during a reset. While integrating this change into the sims, I found the following in
QaudrilateralModel
:I started working to remove it, but this Property is wired through a lot of places in the sim, and it seemed to me like some of the usages were not sound related, so I started getting nervous. I removed it from the one place I could find where it was being passed through to a sound generator, but I thought it best to leave any further modifications to someone who knows the sim better than I. I regression tested my changes, and the sounds seemed to be working fine.
@jessegreenberg - please have a look and see if this can be removed or perhaps renamed. At the very least, the comment should be updated. I'll add a TODO.
The text was updated successfully, but these errors were encountered: