Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Calibrate Device" button and "External Device Callibration" dialog? #442

Open
terracoda opened this issue Jun 8, 2023 · 3 comments
Open

Comments

@terracoda
Copy link
Contributor

@jessegreenberg

  • Please make sure the name of the button, "Callibrate Device" is focusable with the keyboard and voiced on focus and voiced on activation, too with pointer-based input.
  • Also, can you make sure the title in callibration dialog is voices when the dialog open, and that
  • the paragraph at the top voices as a general reading block.

@BLFiedler, I know this is a prototype feature, but if there are any quick language changes that are needed, we should likely do them now. I am not sure we are using "External Device" consistently here and in the Input Tab. Do we just want to go with "Device" here, or do we change the title of the input tab over in issue #315

Here's the current callibration dialog:
Screen Shot 2023-06-08 at 11 13 49 AM

  • Do you want "External Device Callibration" or "Device Callibration" as the dialog title?
  • Future work question: Would it make sense to make the "Calibrate Device" button part of the Input Tab, rather than putting it right in the sim?
@terracoda terracoda added the type:question Further information is requested label Jun 8, 2023
@terracoda
Copy link
Contributor Author

@BLFiedler, regrading the callibration button and the dialog that pops up. Is this the final design for this prototype release? Is not the time to make these parts voice-able?

I noticed the button was not focusable and the button and dialog do not voice. I just want to make sure we all want this work done now before assigning over to @jessegreenberg.

@terracoda
Copy link
Contributor Author

Not sure how this impacts #441. I don't think it does since this dialog is part of the simulation and not the Preferences Menu.

@terracoda terracoda changed the title "Calibrate Device" button and "External Device Callibtation" dialog? "Calibrate Device" button and "External Device Callibration" dialog? Jun 8, 2023
@terracoda
Copy link
Contributor Author

On hold as this is a prototype feature, and there will be no likely scenario where an individual would be using a connected device on their own.

@terracoda terracoda added status:on-hold and removed type:question Further information is requested labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants