Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customized strings in old studio version applies to active language #269

Closed
Tracked by #892 ...
zepumph opened this issue Jan 18, 2023 · 3 comments
Closed
Tracked by #892 ...

Customized strings in old studio version applies to active language #269

zepumph opened this issue Jan 18, 2023 · 3 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jan 18, 2023

This issue is to make sure that whatever work in done in phetsims/joist#899 that should be in ph-scale, gets into it. Marking as blocking. No work to be done until I note it.

@samreid
Copy link
Member

samreid commented Jan 27, 2023

@zepumph and I cherry-picked this and confirmed it works well. We recommend @Nancy-Salpepi double check it in RC.2 following the directions in phetsims/joist#899

@zepumph
Copy link
Member Author

zepumph commented Jan 28, 2023

I confirmed in ph-scale and basics 1.6.0-rc.2 that this is working. Ready for close after QA verification

@Nancy-Salpepi
Copy link

Following the steps in phetsims/joist#899, the sim opens in the current language that is set in studio 1.6 instead of the language it was saved in when using version 1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants