Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening combobox while zoomed in causes screen to pan #152

Closed
Nancy-Salpepi opened this issue Apr 11, 2023 · 6 comments
Closed

Opening combobox while zoomed in causes screen to pan #152

Nancy-Salpepi opened this issue Apr 11, 2023 · 6 comments
Assignees
Labels

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
13.2.1

Browser
Safari and Chrome

Problem description
For phetsims/qa#927, on the Lab Screen, opening the combobox causes the screen to pan down. This doesn't happen in the published prototype, Molecule Shapes, or Concentration.

Steps to reproduce

  1. Zoom in using command + (on a mac) or control + (on Windows)
  2. Pan to the combobox and open

Visuals

comboboxPan.mp4
@AgustinVallejo
Copy link
Contributor

Spoke with @jessegreenberg, he said he'll look into it. Thanks!

@jessegreenberg
Copy link
Contributor

I was not able to investigate this this week. What should happen is that the sim should scroll to the selected item in the combobox. That seems to work for items far down the list but not the first items in the list.

This issue may not block publication of the sim, feel free to check with design team. I will be out of office until 4/24/23 but @jonathanolson said he could take a look if this needs to move forward while I am away. Thanks @jonathanolson!

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Apr 26, 2023

I think this was fixed along with phetsims/scenery#1550 and #157. I can no longer reproduce this issue. I can believe that the problems with focus management in those issues could cause this but I didn't dive into it too deeply.

@Nancy-Salpepi would you mind confirming this is fixed?

@arouinfar
Copy link
Contributor

arouinfar commented Apr 26, 2023

I cannot reproduce on master @jessegreenberg. The sim will pan when the selected ListBox item is outside of the zoomed-in region, but it won't pan if the selected ListBox item is already within the view.

@Nancy-Salpepi
Copy link
Author

This looks good to me too @jessegreenberg. With both the mouse and keyboard nav, panning will occur if the selection is off the screen, but not when it isn't.

@jessegreenberg
Copy link
Contributor

Wonderful. Thanks @arouinfar and @Nancy-Salpepi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants