-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening combobox while zoomed in causes screen to pan #152
Comments
Spoke with @jessegreenberg, he said he'll look into it. Thanks! |
I was not able to investigate this this week. What should happen is that the sim should scroll to the selected item in the combobox. That seems to work for items far down the list but not the first items in the list. This issue may not block publication of the sim, feel free to check with design team. I will be out of office until 4/24/23 but @jonathanolson said he could take a look if this needs to move forward while I am away. Thanks @jonathanolson! |
I think this was fixed along with phetsims/scenery#1550 and #157. I can no longer reproduce this issue. I can believe that the problems with focus management in those issues could cause this but I didn't dive into it too deeply. @Nancy-Salpepi would you mind confirming this is fixed? |
I cannot reproduce on master @jessegreenberg. The sim will pan when the selected ListBox item is outside of the zoomed-in region, but it won't pan if the selected ListBox item is already within the view. |
This looks good to me too @jessegreenberg. With both the mouse and keyboard nav, panning will occur if the selection is off the screen, but not when it isn't. |
Wonderful. Thanks @arouinfar and @Nancy-Salpepi! |
Test device
MacBook Air M1 chip
Operating System
13.2.1
Browser
Safari and Chrome
Problem description
For phetsims/qa#927, on the Lab Screen, opening the combobox causes the screen to pan down. This doesn't happen in the published prototype, Molecule Shapes, or Concentration.
Steps to reproduce
Visuals
comboboxPan.mp4
The text was updated successfully, but these errors were encountered: