Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync button can be extremely small with ?stringTest=dynamic #332

Closed
Tracked by #1134
Nancy-Salpepi opened this issue Jul 31, 2024 · 5 comments
Closed
Tracked by #1134

Sync button can be extremely small with ?stringTest=dynamic #332

Nancy-Salpepi opened this issue Jul 31, 2024 · 5 comments
Labels

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
14.5

Browser
Safari 17.5

Problem description
For phetsims/qa#1121, with ?stringTest=dynamic on the Distribute screen the Sync button can get really tiny and once it does, it will no longer change size when pressing the arrow keys. I'm not sure if this would happen when the "Sync" word is very small in locales other than English. I don't see this issue with ?stringTest=X.

Steps to reproduce

  1. Add ?stringTest=dynamic to the end of the url
  2. Go to the Distribute screen
  3. Press the down arrow 5 times --the button will be really tiny
  4. Then press any combination of arrows --the button will never get larger with text inside.

Visuals

SyncButton.mp4
@Nancy-Salpepi
Copy link
Author

I also see something similar with the Region and Culture combobox.

  1. With ?string test=dynamic added, go to the Localization tab of the Preferences dialog
  2. Press the left arrow once
  3. Press the right arrow once --> the combobox will not return to its original size
  4. Continue to use any combination of arrow keys --it will never return to its original size and can very tiny like the Sync button
regionAndCulture.mp4

@marlitas
Copy link
Contributor

Without having done any investigation this looks like a layout bug. @jonathanolson is this ringing any bells since you've been working in the area? Either way happy to investigate.

@Nancy-Salpepi
Copy link
Author

I see that @pixelzoom made an issue about the combobox part of things here: phetsims/sun#889

@marlitas
Copy link
Contributor

marlitas commented Aug 1, 2024

Fixed in phetsims/sun#889 I will cherry pick the commit there.

@Nancy-Salpepi
Copy link
Author

looks fixed in rc.2
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants