Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated code between AboutDialog and UpdateDialog #557

Open
samreid opened this issue Apr 24, 2019 · 0 comments
Open

Duplicated code between AboutDialog and UpdateDialog #557

samreid opened this issue Apr 24, 2019 · 0 comments
Labels
help-wanted

Comments

@samreid
Copy link
Member

samreid commented Apr 24, 2019

While working on https://github.com/phetsims/phet-io/issues/1454, @chrisklus and I noticed a significant amount of duplicated code between AboutDialog and UpdateDialog:

image

image

We are looking into creating the AboutDialog on startup, and it would be good to understand/isolate this code.

Assigning to @jonathanolson for initial consultation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanolson @samreid @marlitas