NavigationBarScreenButton doesn't extend JoistButton

[pixelzoom]

Other similar buttons (PhetButton, HomeButton) extend JoistButton. NavigationBarScreenButton extends Node, and adds its own highlights and associated logic, duplicating code that's in JoistButton.

@samreid Is there any reason why this is the case? Something I'm missing?

[samreid]

It may be possible to write NavigationBarScreenButton to extend JoistButton. It may be a good way to factor out some code at the moment, but my hesitation is that NavitaionBarScreenButton is more of a radio button and hence has a different feature set than the other JoistButtons.

[pixelzoom]

So JoistButton is really JoistPushButton?

[pixelzoom]

So JoistButton is really JoistPushButton?

Indeed it is. JoistButton.js line 43:
this.buttonModel = new PushButtonModel( options ); // @private

[pixelzoom]

Recommended type hierarchy:

JoistButton
  JoistPushButton
    HomeButton
    PhetButton
  JoistRadioButton
    NavigationBarScreenButton

[samreid]

That seems like a nice intermediate solution, though perhaps a better long term solution would involve moving some of this to sun and/or integrating it with the sun button/radiobutton implementations.

[pixelzoom]

Still seems like a lot of work. I'm going to defer this unless there's no other way that I can finish #241.

[pixelzoom]

I was able to complete #241 without addressing this. So unassigning because this is unlikely to be addressed in the near future, and it's not clear that that I should be the one addressing it.

[pixelzoom]

Still a problem.... In general, joist really needs a full overhaul of its buttons (home screen, nav bar, etc.)