Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the thermometer be linked with ambiance sounds? #264

Closed
CliffordH123 opened this issue Jan 23, 2023 · 1 comment
Closed

Should the thermometer be linked with ambiance sounds? #264

CliffordH123 opened this issue Jan 23, 2023 · 1 comment
Labels
type:bug Something isn't working

Comments

@CliffordH123
Copy link

CliffordH123 commented Jan 23, 2023

Test device
ASUS ROG STRIX Windows 10 Pro

Operating System
Version 10.0.19044 Build 19044

Browser
Firefox/Chrome

Noticed on Prototype test (RC-lite): Greenhouse Effect 1.1.0-rc.2 phetsims/qa#885 that the surface thermometer check box will also turn off the background music/ambiance track. This leaves only the noise of the photons bouncing around (in the case of the screens which have photons) or the low noise of the waves (for the wave screen). Seems like this is not the intention but wasn't sure.

Steps to reproduce:

  1. Begin any of the various screens
  2. Allow ambiance "music" and sound of wave/photons to being
  3. Disable the surface thermometer and notice that "music" is off
    surface therm
  4. Re-enable surface thermometer and notice return of "music"
@arouinfar
Copy link
Contributor

Thanks @CliffordH123 that is indeed the intended behavior. The more musical sound is mapped to the surface temperature. So long as Surface Thermometer or Show Surface Temperature (Waves Screen) is checked, the sound should be heard.

@KatieWoe KatieWoe added the type:bug Something isn't working label Jan 24, 2023
@KatieWoe KatieWoe transferred this issue from phetsims/qa Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants