-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should I be able to press and hold Step Forward button with keyboard nav? #262
Comments
Thanks @Nancy-Salpepi. That's a great question. It seems fairly universal that holding There are likely historic or technical reasons for why things behave this way, but I don't know them. @jessegreenberg?
I think this is the expected behavior, but @jbphet can confirm. @jbphet I don't think we need to do anything here from the prototype. It's unclear that we will make any changes, but whatever we do would apply to multiple sims likely requiring a MR. Greenhouse could get patched with the fix then. |
Yes, the difference comes from the browser/operating system. Most apps will have this difference between enter and spacebar. A while ago we talked about making them behave the same but decided against it because it would be some extra work to go against the convention. |
Thanks for the explanation @jessegreenberg. Sounds like this is a known and expected behavior. @Nancy-Salpepi should this go in the QA book? |
Sure! I can add something in @arouinfar 🙂 |
@arouinfar said, based on the previous comments:
I think that means there is nothing that needs to be changed in the code. Closing. |
Test device
MacBook Air (m1 chip)
Operating System
13.1
Browser
safari/chrome
Problem description
For phetsims/qa#885, I noticed that if I am using the mouse, I can press and hold the step forward button, but with keyboard nav, pressing the
space bar
only allows the sim to step forward once.Pressing and holding the
Return
(Enter) button, allows for a continuous step forward, but the sound associated with pressing a button is heard repeatedly.I was wondering if we should be able to continuously step forward by holding down the space bar to be more consistent?
Noting: The current behavior is the same as other published sims with Keyboard Nav and Step Forward (Fourier and Molecules and Light).
Steps to reproduce
space bar
--sim steps forward onceThe text was updated successfully, but these errors were encountered: