Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steam hiss may play in State even when option is not on #279

Closed
KatieWoe opened this issue Mar 30, 2022 · 4 comments
Closed

Steam hiss may play in State even when option is not on #279

KatieWoe opened this issue Mar 30, 2022 · 4 comments

Comments

@KatieWoe
Copy link
Contributor

Device
Mac and iPad (but not able to reproduce so far on Win 11)
OS
MacOS 12.3 and iPadOS 15
Browser
Safari and Chrome
Problem Description
For phetsims/qa#791
When in the state wrapper, if you move the bottom sim while the temp is dropping, then it will start playing the hissing sound as temp drops, even when that option isn't on
Steps to Reproduce

  1. Go to State wrapper on an Apple device
  2. Make sure extra sounds are off
  3. Set the refresh rate to about 3500. Other values work, but I found around this value easiest
  4. In top sim, create a high temp and let it start to drop
  5. In bottom sim, when state updates and it has a dropping temp, move the book in bottom sim to raise temp again
  6. When state updates again, the hissing sound will occur and will continue to happen even without the setup

Visuals

Image.from.iOS.MOV
@KatieWoe
Copy link
Contributor Author

KatieWoe commented Apr 1, 2022

I take this statement back:

(but not able to reproduce so far on Win 11)

I have gotten it to occur on Win 11, but it seems less consistent.

@stemilymill
Copy link

stemilymill commented Apr 7, 2022

On Win10 Chrome, the sim launched from studio plays the hiss when extra sounds are turned off.
This also happens when the sim is saved from studio and opened.

to reproduce: rub the books together before launching sim preview or saving.

@zepumph
Copy link
Member

zepumph commented Jul 26, 2022

This has been fixed by removing the "extraSoundsEnabledProperty" from state. Can you please confirm this is fixed on master and feel free to close.

@KatieWoe
Copy link
Contributor Author

It seems fixed on master. I wasn't able to replicate it on Win 11 chrome. Will reopen if it shows up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants