Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User request: new team colors (color customization) #289

Open
oliver-phet opened this issue Sep 22, 2021 · 11 comments
Open

User request: new team colors (color customization) #289

oliver-phet opened this issue Sep 22, 2021 · 11 comments

Comments

@oliver-phet
Copy link

I was wondering if you could possibly change the color of the figures in the Forces and Motion: Basics simulation? In my school we are constantly dealing with gangs and their influences. The two major colors of rival gangs are blue and red. It would make the conversation a lot better if it wasn't blue versus red.

ON: This request is very specific (and there's likely not any combination of colors that don't have consequences in some community), but I'm posting an issue because this seems to be another example where having additional customization options would be useful to our users.

@oliver-phet oliver-phet changed the title User request: new team colors User request: new team colors (color customization) Sep 22, 2021
@arouinfar
Copy link

I think we likely create a preference for the team colors and hook it up to a query parameter. Let's consider when we revisit this sim, unassigning myself for now.

@arouinfar arouinfar removed their assignment Jun 23, 2023
@amanda-phet
Copy link
Contributor

Tagging for design meeting to discuss if we want to address this with #304

@amanda-phet
Copy link
Contributor

It would be relatively easy to recolor this artwork.

We may want to rename the code references from blue/red to left/right so it is color-agnostic (and consistent with the direction of the forces).

Considering replacing blue with purple. We will confirm that these colors pass color blindness.

@amanda-phet
Copy link
Contributor

I'd like to confirm here that we should add a Simulation tab to the preferences dialog, and add an option for the Net Force pullers. Not sure what to call it, or how to style it, but I'm thinking rectangular radio buttons with images of the colors, or aqua radio buttons that say "blue/red" and "purple/orange."

amanda-phet added a commit that referenced this issue Aug 22, 2024
@amanda-phet
Copy link
Contributor

Orange and Purple pullers are uploaded!

For the Preferences, can you add a Simulation tab with the following for the setting:

Net Force Puller Colors

  • Blue and Red (selected)
  • Purple and Orange

Also, can you make this a query parameter, so it is selected at sim startup for the teachers who want this feature? I'm not sure what to name it... perhaps pullerColor and the options can be blue or purple?

@Luisav1
Copy link
Contributor

Luisav1 commented Aug 23, 2024

I've added the the option to change the pullers color in the preferences tab like so:
image

Additionally, there is now a query parameter pullercolor that can be set at startup. The valid values are blueRed and purpleOrange. I found it clearer to use these names instead of just blue and purple throughout the code, but I'm open to any suggestions to improve them.

I still need to change the FlagNode that's displayed when a color wins to reflect these new colors.

@amanda-phet
Copy link
Contributor

OK great!

Can you make sure the name of the control is in bold? I assumed it was handled by common code, but it might just be that we have to manually make it bold every time we add a preference.

@Luisav1
Copy link
Contributor

Luisav1 commented Aug 23, 2024

Yes, that was an easy fix! I changed which font from the PreferencesDialog it was using.

The flag node is now updated as well:
image
image

This is all now ready for your review @amanda-phet.

@amanda-phet
Copy link
Contributor

This looks like it's working great. Assigning to @oliver-phet to reply to the user once this sim is published.

@oliver-phet
Copy link
Author

Will this issue receive a comment when the update is published?

amanda-phet added a commit that referenced this issue Nov 19, 2024
@Nancy-Salpepi
Copy link

For phetsims/qa#1179, confirming that the purple/orange figures have been added. The query parameter and option in the Simulation tab of the Preferences menu are working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants