Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Republish Density when we publish Buoyancy #190

Closed
zepumph opened this issue Feb 15, 2024 · 4 comments
Closed

Republish Density when we publish Buoyancy #190

zepumph opened this issue Feb 15, 2024 · 4 comments
Labels
meeting:design type:question Further information is requested

Comments

@zepumph
Copy link
Member

zepumph commented Feb 15, 2024

This was asked today during PhET-iO meeting. Especially with the addition of alt input + ui sound, it may be worth republishing this. Let's talk about it!
@zepumph zepumph mentioned this issue Feb 22, 2024
Open
@samreid samreid changed the title Republish when we publish Buoyancy? Republish Density when we publish Buoyancy Apr 10, 2024
@zepumph
Copy link
Member Author

zepumph commented May 16, 2024

Today the dev team discussed this and feel like we should definitely publish this sim as part of Buoyancy. If there isn't time, then we can cut that corner, but many changes have gone into this code base, and it would be best to have all three sims in the suite be on the same shas.

@zepumph zepumph closed this as completed May 16, 2024
@zepumph zepumph reopened this May 16, 2024
@zepumph
Copy link
Member Author

zepumph commented May 16, 2024

oops, not closing

@zepumph zepumph added the type:question Further information is requested label May 20, 2024
@zepumph
Copy link
Member Author

zepumph commented Jun 3, 2024

Over in #194 (comment) we fixed a user-reported bug that should be republished.

@zepumph
Copy link
Member Author

zepumph commented Jun 3, 2024

We discussed this with @DianaTavares and are all on the same page about this. Closing

@zepumph zepumph closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meeting:design type:question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph