-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BC break] PJAX container selection #13
Comments
I've added a pull request #14 to implement this fallback behavior |
Hi, |
I see where this problem is coming from. I'm not running the latest Yii2 core, because that would take a lot of Q&A. I'm still on 2.0.6 from earlier this year. The data-pjax-container attribute has been added in 2.0.7. I'll see if I can at least upgrade to that version. |
I added the dependency constraint. Thank you for taking the time to report this. |
I've been using this module for some time. But commit a043f48 broke the current implementation for me. My grids all have the grid-view class, but they don't have the data-pjax-container attribute.
Would it be possible to prevent these kind of breaking changes in the future? For example, by testing on the data attribute first and fall back to the original behavior.
In the current setup, I have to add an identifier to each PJAX begin call and supply that to the gridview as a pjax-container.
The text was updated successfully, but these errors were encountered: