Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC break] PJAX container selection #13

Closed
ebuzzz opened this issue Dec 23, 2016 · 4 comments
Closed

[BC break] PJAX container selection #13

ebuzzz opened this issue Dec 23, 2016 · 4 comments

Comments

@ebuzzz
Copy link

ebuzzz commented Dec 23, 2016

I've been using this module for some time. But commit a043f48 broke the current implementation for me. My grids all have the grid-view class, but they don't have the data-pjax-container attribute.

Would it be possible to prevent these kind of breaking changes in the future? For example, by testing on the data attribute first and fall back to the original behavior.

In the current setup, I have to add an identifier to each PJAX begin call and supply that to the gridview as a pjax-container.

@ebuzzz
Copy link
Author

ebuzzz commented Dec 23, 2016

I've added a pull request #14 to implement this fallback behavior

@arisk
Copy link
Contributor

arisk commented Dec 23, 2016

Hi,
Why do you need to add an identifier to Pjax::begin? If you are using the Pjax widget you should always have a data-pjax-container attribute.

@ebuzzz
Copy link
Author

ebuzzz commented Dec 23, 2016

I see where this problem is coming from. I'm not running the latest Yii2 core, because that would take a lot of Q&A. I'm still on 2.0.6 from earlier this year.

The data-pjax-container attribute has been added in 2.0.7. I'll see if I can at least upgrade to that version.
Would it be possible to add a dependency for yii2 >= 2.0.7 in your composer.json? To prevent the same problem for others?

@arisk arisk closed this as completed in ddec055 Dec 23, 2016
@arisk
Copy link
Contributor

arisk commented Dec 23, 2016

I added the dependency constraint. Thank you for taking the time to report this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants