From 4aa41626f222133d60675f797c82f8689bba9334 Mon Sep 17 00:00:00 2001 From: Ratakondala Arun Date: Wed, 20 Jul 2022 15:31:13 +0530 Subject: [PATCH] fix(generator): fixed typo in a method --- lib/abs/icon_generator.dart | 4 ++-- lib/web/web_icon_generator.dart | 2 +- test/abs/icon_generator_test.dart | 12 +++++----- test/abs/icon_generator_test.mocks.dart | 30 +++++++++---------------- test/web/web_icon_generator_test.dart | 2 +- 5 files changed, 21 insertions(+), 29 deletions(-) diff --git a/lib/abs/icon_generator.dart b/lib/abs/icon_generator.dart index 83e4721dc5..4d48f6265a 100644 --- a/lib/abs/icon_generator.dart +++ b/lib/abs/icon_generator.dart @@ -16,7 +16,7 @@ abstract class IconGenerator { /// Should return `true` if this platform /// has all the requirments to create icons. /// This runs before to [createIcons] - bool validateRequirments(); + bool validateRequirements(); } /// Provides easy access to user arguments and configuration @@ -63,7 +63,7 @@ void generateIconsFor({ logger.verbose('Validating platform requirments for ${platform.platformName}'); // in case a platform throws an exception it should not effect other platforms try { - if (!platform.validateRequirments()) { + if (!platform.validateRequirements()) { logger.error('Requirments failed for platform ${platform.platformName}. Skipped'); progress.cancel(); continue; diff --git a/lib/web/web_icon_generator.dart b/lib/web/web_icon_generator.dart index 0324d151e3..76706db09c 100644 --- a/lib/web/web_icon_generator.dart +++ b/lib/web/web_icon_generator.dart @@ -71,7 +71,7 @@ class WebIconGenerator extends IconGenerator { } @override - bool validateRequirments() { + bool validateRequirements() { // check if web config exists context.logger.verbose('Checking webconfig...'); final webConfig = context.webConfig; diff --git a/test/abs/icon_generator_test.dart b/test/abs/icon_generator_test.dart index 296acada6a..931a488cea 100644 --- a/test/abs/icon_generator_test.dart +++ b/test/abs/icon_generator_test.dart @@ -29,7 +29,7 @@ void main() { )); }); test('should execute createIcons() when validateRequiremnts() returns true', () { - when(mockGenerator.validateRequirments()).thenReturn(true); + when(mockGenerator.validateRequirements()).thenReturn(true); generateIconsFor( config: mockFLIConfig, flavor: null, @@ -37,12 +37,12 @@ void main() { logger: logger, platforms: (context) => [mockGenerator], ); - verify(mockGenerator.validateRequirments()).called(equals(1)); + verify(mockGenerator.validateRequirements()).called(equals(1)); verify(mockGenerator.createIcons()).called(equals(1)); }); test('should not execute createIcons() when validateRequiremnts() returns false', () { - when(mockGenerator.validateRequirments()).thenReturn(false); + when(mockGenerator.validateRequirements()).thenReturn(false); generateIconsFor( config: mockFLIConfig, flavor: null, @@ -50,12 +50,12 @@ void main() { logger: logger, platforms: (context) => [mockGenerator], ); - verify(mockGenerator.validateRequirments()).called(equals(1)); + verify(mockGenerator.validateRequirements()).called(equals(1)); verifyNever(mockGenerator.createIcons()); }); test('should skip platform if any exception occured', () { - when(mockGenerator.validateRequirments()).thenReturn(true); + when(mockGenerator.validateRequirements()).thenReturn(true); when(mockGenerator.createIcons()).thenThrow(Exception('should-skip-platform')); generateIconsFor( config: mockFLIConfig, @@ -64,7 +64,7 @@ void main() { logger: logger, platforms: (context) => [mockGenerator], ); - verify(mockGenerator.validateRequirments()).called(equals(1)); + verify(mockGenerator.validateRequirements()).called(equals(1)); verify(mockGenerator.createIcons()).called(equals(1)); expect(() => mockGenerator.createIcons(), throwsException); }); diff --git a/test/abs/icon_generator_test.mocks.dart b/test/abs/icon_generator_test.mocks.dart index eca08ac033..e75828592b 100644 --- a/test/abs/icon_generator_test.mocks.dart +++ b/test/abs/icon_generator_test.mocks.dart @@ -3,8 +3,7 @@ // Do not manually edit this file. import 'package:flutter_launcher_icons/abs/icon_generator.dart' as _i2; -import 'package:flutter_launcher_icons/flutter_launcher_icons_config.dart' - as _i3; +import 'package:flutter_launcher_icons/flutter_launcher_icons_config.dart' as _i3; import 'package:mockito/mockito.dart' as _i1; // ignore_for_file: type=lint @@ -17,22 +16,19 @@ import 'package:mockito/mockito.dart' as _i1; // ignore_for_file: unnecessary_parenthesis // ignore_for_file: camel_case_types -class _FakeIconGeneratorContext_0 extends _i1.Fake - implements _i2.IconGeneratorContext {} +class _FakeIconGeneratorContext_0 extends _i1.Fake implements _i2.IconGeneratorContext {} /// A class which mocks [FlutterLauncherIconsConfig]. /// /// See the documentation for Mockito's code generation for more information. -class MockFlutterLauncherIconsConfig extends _i1.Mock - implements _i3.FlutterLauncherIconsConfig { +class MockFlutterLauncherIconsConfig extends _i1.Mock implements _i3.FlutterLauncherIconsConfig { MockFlutterLauncherIconsConfig() { _i1.throwOnMissingStub(this); } @override Map toJson() => - (super.noSuchMethod(Invocation.method(#toJson, []), - returnValue: {}) as Map); + (super.noSuchMethod(Invocation.method(#toJson, []), returnValue: {}) as Map); } /// A class which mocks [IconGenerator]. @@ -44,18 +40,14 @@ class MockIconGenerator extends _i1.Mock implements _i2.IconGenerator { } @override - _i2.IconGeneratorContext get context => (super.noSuchMethod( - Invocation.getter(#context), - returnValue: _FakeIconGeneratorContext_0()) as _i2.IconGeneratorContext); + _i2.IconGeneratorContext get context => + (super.noSuchMethod(Invocation.getter(#context), returnValue: _FakeIconGeneratorContext_0()) + as _i2.IconGeneratorContext); @override - String get platformName => - (super.noSuchMethod(Invocation.getter(#platformName), returnValue: '') - as String); + String get platformName => (super.noSuchMethod(Invocation.getter(#platformName), returnValue: '') as String); @override - void createIcons() => super.noSuchMethod(Invocation.method(#createIcons, []), - returnValueForMissingStub: null); + void createIcons() => super.noSuchMethod(Invocation.method(#createIcons, []), returnValueForMissingStub: null); @override - bool validateRequirments() => - (super.noSuchMethod(Invocation.method(#validateRequirments, []), - returnValue: false) as bool); + bool validateRequirements() => + (super.noSuchMethod(Invocation.method(#validateRequirments, []), returnValue: false) as bool); } diff --git a/test/web/web_icon_generator_test.dart b/test/web/web_icon_generator_test.dart index 28548c2e09..644e2e170a 100644 --- a/test/web/web_icon_generator_test.dart +++ b/test/web/web_icon_generator_test.dart @@ -39,7 +39,7 @@ void main() { // end to end test test('should generate valid icons', () async { - expect(generator.validateRequirments(), isTrue); + expect(generator.validateRequirements(), isTrue); generator.createIcons(); await expectLater( d.dir('fli_test', [