From 8ce229f945f184185d9a522f5524d711f8c91486 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Viana?= <57032457+vollous@users.noreply.github.com> Date: Wed, 10 Jul 2024 15:41:21 +0100 Subject: [PATCH 1/5] Fix bug, missing "&" --- standalone/TunnelingPath.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/standalone/TunnelingPath.cpp b/standalone/TunnelingPath.cpp index 1954a8627..655cb2950 100644 --- a/standalone/TunnelingPath.cpp +++ b/standalone/TunnelingPath.cpp @@ -80,7 +80,7 @@ int main() BounceActionInt *ClosestBounceActionInt; std::cout << "Found a transitions with Tp =\t" << bounce.GetPercolationTemp() << " GeV.\n"; - for (auto BAInt : bounce.SolutionList) + for (auto &BAInt : bounce.SolutionList) { if (abs(BAInt.T - bounce.GetPercolationTemp()) < errorTtoTp) { From efc91077baff0f3d4ae0e0200fda959d947fc9f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Viana?= <57032457+vollous@users.noreply.github.com> Date: Wed, 10 Jul 2024 15:41:48 +0100 Subject: [PATCH 2/5] Version bump --- CMakeLists.txt | 2 +- README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 69312602c..6cd0def33 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -6,7 +6,7 @@ cmake_minimum_required(VERSION 3.23) project( BSMPT - VERSION 3.0.5 + VERSION 3.0.6 LANGUAGES C CXX DESCRIPTION "BSMPT - Beyond the Standard Model Phase Transitions : A C++ package for the computation of the EWPT in BSM models" diff --git a/README.md b/README.md index 53b9077d4..59b697b25 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ SPDX-FileCopyrightText: 2021 Philipp Basler, Margarete Mühlleitner and Jonas M SPDX-License-Identifier: GPL-3.0-or-later --> -Program: BSMPT version 3.0.5 +Program: BSMPT version 3.0.6 Released by: Philipp Basler, Lisa Biermann, Margarete Mühlleitner, Jonas Müller, Rui Santos and João Viana From 33d4e476f166d0a07cc3b18b77b8c702a6091793 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Viana?= <57032457+vollous@users.noreply.github.com> Date: Wed, 10 Jul 2024 23:42:26 +0100 Subject: [PATCH 3/5] Convert loop to const auto &BAInt --- include/BSMPT/utility/const_velocity_spline.h | 4 ++-- src/utility/const_velocity_spline.cpp | 4 ++-- standalone/TunnelingPath.cpp | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/BSMPT/utility/const_velocity_spline.h b/include/BSMPT/utility/const_velocity_spline.h index c2add41f7..2f4429f80 100644 --- a/include/BSMPT/utility/const_velocity_spline.h +++ b/include/BSMPT/utility/const_velocity_spline.h @@ -189,12 +189,12 @@ class cvspline * @param l * @return std::vector */ - std::vector operator()(double l); + std::vector operator()(double l) const; /** * @brief print the current knots of the spline * */ - void print_path(); + void print_path() const; /** * @brief save the knots of the splien into a file * diff --git a/src/utility/const_velocity_spline.cpp b/src/utility/const_velocity_spline.cpp index c10b36f42..907e39d55 100644 --- a/src/utility/const_velocity_spline.cpp +++ b/src/utility/const_velocity_spline.cpp @@ -266,7 +266,7 @@ std::vector cvspline::d2l(double l) return rr; } -std::vector cvspline::operator()(double l) +std::vector cvspline::operator()(double l) const { // Calculates the VEV at the position l in spline length, l = l_to_x(l); // Convert from spline length to linear length. @@ -278,7 +278,7 @@ std::vector cvspline::operator()(double l) return r; } -void cvspline::print_path() +void cvspline::print_path() const { int wid = 15; diff --git a/standalone/TunnelingPath.cpp b/standalone/TunnelingPath.cpp index 655cb2950..552aeb127 100644 --- a/standalone/TunnelingPath.cpp +++ b/standalone/TunnelingPath.cpp @@ -77,10 +77,10 @@ int main() bounce.CalculatePercolationTemp(); if (bounce.GetPercolationTemp() == -1) continue; double errorTtoTp = 1e100; - BounceActionInt *ClosestBounceActionInt; + BounceActionInt const *ClosestBounceActionInt; std::cout << "Found a transitions with Tp =\t" << bounce.GetPercolationTemp() << " GeV.\n"; - for (auto &BAInt : bounce.SolutionList) + for (const auto &BAInt : bounce.SolutionList) { if (abs(BAInt.T - bounce.GetPercolationTemp()) < errorTtoTp) { From d172e5f7d2c03f02bf87a10a639606028cbf922f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Viana?= <57032457+vollous@users.noreply.github.com> Date: Tue, 23 Jul 2024 13:50:17 +0100 Subject: [PATCH 4/5] Another version bump --- CMakeLists.txt | 2 +- README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 6cd0def33..61c7245b9 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -6,7 +6,7 @@ cmake_minimum_required(VERSION 3.23) project( BSMPT - VERSION 3.0.6 + VERSION 3.0.7 LANGUAGES C CXX DESCRIPTION "BSMPT - Beyond the Standard Model Phase Transitions : A C++ package for the computation of the EWPT in BSM models" diff --git a/README.md b/README.md index 59b697b25..2465d7ba5 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ SPDX-FileCopyrightText: 2021 Philipp Basler, Margarete Mühlleitner and Jonas M SPDX-License-Identifier: GPL-3.0-or-later --> -Program: BSMPT version 3.0.6 +Program: BSMPT version 3.0.7 Released by: Philipp Basler, Lisa Biermann, Margarete Mühlleitner, Jonas Müller, Rui Santos and João Viana From 66c4f54c4bfcb90017513ca8f8d8cdb1edad3040 Mon Sep 17 00:00:00 2001 From: Philipp Basler <28863303+phbasler@users.noreply.github.com> Date: Wed, 31 Jul 2024 06:37:52 +0200 Subject: [PATCH 5/5] Apply suggestions from code review --- CMakeLists.txt | 2 +- README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 61c7245b9..6cd0def33 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -6,7 +6,7 @@ cmake_minimum_required(VERSION 3.23) project( BSMPT - VERSION 3.0.7 + VERSION 3.0.6 LANGUAGES C CXX DESCRIPTION "BSMPT - Beyond the Standard Model Phase Transitions : A C++ package for the computation of the EWPT in BSM models" diff --git a/README.md b/README.md index f178ace70..299b8e9a2 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ SPDX-FileCopyrightText: 2021 Philipp Basler, Margarete Mühlleitner and Jonas M SPDX-License-Identifier: GPL-3.0-or-later --> -Program: BSMPT version 3.0.7 +Program: BSMPT version 3.0.6 Released by: Philipp Basler, Lisa Biermann, Margarete Mühlleitner, Jonas Müller, Rui Santos and João Viana