Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: changing to another method is very slow #639

Closed
MarcusDenker opened this issue Dec 7, 2023 · 5 comments · Fixed by #640
Closed

Debugger: changing to another method is very slow #639

MarcusDenker opened this issue Dec 7, 2023 · 5 comments · Fixed by #640

Comments

@MarcusDenker
Copy link
Contributor

If you are in the debugger, changing to another entry in the stack is now very slow.

just do "command ." and click on doDrawCycleWith: or use the arrow keys

@MarcusDenker
Copy link
Contributor Author

MarcusDenker commented Dec 7, 2023

This might be related to #632 or #630

@MarcusDenker
Copy link
Contributor Author

Even scrolling the left inspector pane if there are more items than fit in the view feels sluggish, as if it re-prints everything for the scroll refresh

@MarcusDenker
Copy link
Contributor Author

Changing the window size of the debugger is very slow, too

@MarcusDenker
Copy link
Contributor Author

I found it: it is #635

go to StRawInspectionPresenter>>#valuesColumn, comment out "beEditable;", and it is fast again

valuesColumn

	^ SpStringTableColumn new
		title: 'Value';
		evaluated: #stringValue;
		"beEditable;"
		onAcceptEdition: [ :node :value | 
			self write: node value: value.
			self updatePresenterTitle ];
		sortFunction: #stringValue ascending;
		yourself

@MarcusDenker
Copy link
Contributor Author

MarcusDenker commented Dec 7, 2023

I did a revert PR: #640

@MarcusDenker MarcusDenker linked a pull request Dec 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant