Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewTools-FileBrowser should not use StInspector but switch to StObjectInspectorPresenter #616

Closed
astares opened this issue Nov 21, 2023 · 0 comments · Fixed by #617
Closed

Comments

@astares
Copy link
Contributor

astares commented Nov 21, 2023

The package "NewTools-FileBrowser" creates an extension on StInspector which is a deprecated class in Spec2 now.
The method provided as extension is StInspector class>>#instanciateOn:

image

There is only a single sender StFBInspectPreviewer>>#previewActionOn: of this method #instanciateOn:
that we can adopt from:

previewActionOn: aFileReference
	^ StInspector instanciateOn: aFileReference

to

previewActionOn: aFileReference
	^ StObjectInspectorPresenter onObject: aFileReference

to use StObjectInspectorPresenter instead of the deprecated StInspector class.

@astares astares changed the title NewTools-FileBrowser should not use StInspector but switch to NewTools-FileBrowser should not use StInspector but switch to StObjectInspectorPresenter Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant