From edf9ba70c60f048a7cdc07eb13d4f4354f0ac9f3 Mon Sep 17 00:00:00 2001 From: Carolina Hernandez Date: Sun, 29 Oct 2023 19:53:33 -0300 Subject: [PATCH] operations working properly --- src/NewTools-Scopes-Browser/ScopeNode.class.st | 3 ++- src/NewTools-Scopes-Browser/ScopeScopeNode.class.st | 2 +- src/NewTools-Scopes-Browser/ScopesPresenter.class.st | 7 ++++++- src/NewTools-Scopes/ScopesManager.class.st | 5 ----- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/NewTools-Scopes-Browser/ScopeNode.class.st b/src/NewTools-Scopes-Browser/ScopeNode.class.st index 2d2b7db28..c05e2ad92 100644 --- a/src/NewTools-Scopes-Browser/ScopeNode.class.st +++ b/src/NewTools-Scopes-Browser/ScopeNode.class.st @@ -79,7 +79,8 @@ ScopeNode >> isScopeNode [ { #category : 'accessing' } ScopeNode >> label [ - ^ self value name + + ^ self value name , ' [package: ' , self value package name , ']' ] { #category : 'accessing' } diff --git a/src/NewTools-Scopes-Browser/ScopeScopeNode.class.st b/src/NewTools-Scopes-Browser/ScopeScopeNode.class.st index 13d96618e..f359906a0 100644 --- a/src/NewTools-Scopes-Browser/ScopeScopeNode.class.st +++ b/src/NewTools-Scopes-Browser/ScopeScopeNode.class.st @@ -14,7 +14,7 @@ ScopeScopeNode >> children [ | fullPackages orphanClasses packageChildren classChildren clss | clss := self value classes. -self halt. + fullPackages := ScopesManager fullPackagesFrom: clss. orphanClasses := ScopesManager orphanClassesIn: clss diff --git a/src/NewTools-Scopes-Browser/ScopesPresenter.class.st b/src/NewTools-Scopes-Browser/ScopesPresenter.class.st index 137a27e04..59401d6b5 100644 --- a/src/NewTools-Scopes-Browser/ScopesPresenter.class.st +++ b/src/NewTools-Scopes-Browser/ScopesPresenter.class.st @@ -97,6 +97,10 @@ ScopesPresenter >> argumentsListMenu [ name: 'Rename'; visibleIf: [ scopesTree selectedItem isScopeNode ]; action: [ self renameSelectedScope ] ]; + addItem: [ :anItem | + anItem + name: 'Inspect'; + action: [ scopesTree selectedItem inspect ] ]; addItem: [ :anItem | anItem name: 'Open on Calypso'; @@ -112,7 +116,8 @@ ScopesPresenter >> argumentsListMenu [ anItem name: 'Class references'; visibleIf: [ scopesTree selectedItem isClassNode ]; - action: [ self showReferencesToClass: scopesTree selectedItem value] ] ]; + action: [ + self showReferencesToClass: scopesTree selectedItem value ] ] ]; addGroup: [ :aGroup | aGroup addItem: [ :anItem | diff --git a/src/NewTools-Scopes/ScopesManager.class.st b/src/NewTools-Scopes/ScopesManager.class.st index ba50ef8ea..55a23056b 100644 --- a/src/NewTools-Scopes/ScopesManager.class.st +++ b/src/NewTools-Scopes/ScopesManager.class.st @@ -97,11 +97,6 @@ ScopesManager class >> newScopeFrom: scopeA and: scopeB [ ^ self newScopeFrom: fullPackages , classesInterAB ] -{ #category : 'operations' } -ScopesManager class >> newScopeFrom: scopeA or: scopeB [ - ^ scopeA | scopeB -] - { #category : 'operations' } ScopesManager class >> newScopeFromNot: scope [