From 45272a566f8c8e2efdf318b50e57a4861f759418 Mon Sep 17 00:00:00 2001 From: Pablo Tesone Date: Mon, 18 Mar 2024 16:16:49 +0100 Subject: [PATCH] Fix https://github.com/pharo-project/pharo/issues/16299 - Correctly initializing message list. - Fixing command descriptions --- .../StMessageImplementorsCommand.class.st | 6 ++++++ .../StMessageSendersCommand.class.st | 6 ++++++ src/NewTools-MethodBrowsers/StMessageUsersCommand.class.st | 6 ++++++ .../StVersionBrowserPresenter.class.st | 6 ++++-- src/NewTools-MethodBrowsers/StVersionRevertCommand.class.st | 4 ++-- 5 files changed, 24 insertions(+), 4 deletions(-) diff --git a/src/NewTools-MethodBrowsers/StMessageImplementorsCommand.class.st b/src/NewTools-MethodBrowsers/StMessageImplementorsCommand.class.st index 7a2c2423..2295ef3e 100644 --- a/src/NewTools-MethodBrowsers/StMessageImplementorsCommand.class.st +++ b/src/NewTools-MethodBrowsers/StMessageImplementorsCommand.class.st @@ -9,6 +9,12 @@ Class { #tag : 'Commands' } +{ #category : 'default' } +StMessageImplementorsCommand class >> defaultDescription [ + + ^ 'Browse all methods implementing the selector of the current method' +] + { #category : 'accessing' } StMessageImplementorsCommand class >> defaultName [ diff --git a/src/NewTools-MethodBrowsers/StMessageSendersCommand.class.st b/src/NewTools-MethodBrowsers/StMessageSendersCommand.class.st index 59e95089..61a6ec6f 100644 --- a/src/NewTools-MethodBrowsers/StMessageSendersCommand.class.st +++ b/src/NewTools-MethodBrowsers/StMessageSendersCommand.class.st @@ -9,6 +9,12 @@ Class { #tag : 'Commands' } +{ #category : 'default' } +StMessageSendersCommand class >> defaultDescription [ + + ^ 'Browse all methods sending messages with the selector of the current method' +] + { #category : 'accessing' } StMessageSendersCommand class >> defaultName [ diff --git a/src/NewTools-MethodBrowsers/StMessageUsersCommand.class.st b/src/NewTools-MethodBrowsers/StMessageUsersCommand.class.st index a49b2e1b..386ab9bb 100644 --- a/src/NewTools-MethodBrowsers/StMessageUsersCommand.class.st +++ b/src/NewTools-MethodBrowsers/StMessageUsersCommand.class.st @@ -9,6 +9,12 @@ Class { #tag : 'Commands' } +{ #category : 'default' } +StMessageUsersCommand class >> defaultDescription [ + + ^ 'Browse all methods using the selector of the current method' +] + { #category : 'accessing' } StMessageUsersCommand class >> defaultName [ diff --git a/src/NewTools-MethodBrowsers/StVersionBrowserPresenter.class.st b/src/NewTools-MethodBrowsers/StVersionBrowserPresenter.class.st index 69eea18a..2baeb956 100644 --- a/src/NewTools-MethodBrowsers/StVersionBrowserPresenter.class.st +++ b/src/NewTools-MethodBrowsers/StVersionBrowserPresenter.class.st @@ -204,8 +204,10 @@ StVersionBrowserPresenter >> doRevert [ StVersionBrowserPresenter >> initializePresenters [ messageList := self newMessageList. - toolbarPresenter := self newMessageToolbar. - + toolbarPresenter := self newMessageToolbar + messageList: messageList; + yourself. + messageList topologicSort: false; sortingBlock: [ :a | a annotationNamed: #versionIndex ifAbsent: [ 0 ] ] ascending. diff --git a/src/NewTools-MethodBrowsers/StVersionRevertCommand.class.st b/src/NewTools-MethodBrowsers/StVersionRevertCommand.class.st index e7376ca7..5362423b 100644 --- a/src/NewTools-MethodBrowsers/StVersionRevertCommand.class.st +++ b/src/NewTools-MethodBrowsers/StVersionRevertCommand.class.st @@ -6,10 +6,10 @@ Class { #tag : 'Commands' } -{ #category : 'accessing' } +{ #category : 'default' } StVersionRevertCommand class >> defaultDescription [ - ^ 'Compare selected version to the current version' + ^ 'Revert the current method to the selected version' ] { #category : 'accessing' }