From de5a515be3ad2439b0d8e1f02cc25a1cc11f3e55 Mon Sep 17 00:00:00 2001 From: Esteban Lorenzano Date: Sat, 3 Feb 2024 09:13:23 +0100 Subject: [PATCH 1/2] tehre should not be need of remove here --- src/NewTools-Core/StPharoJobManager.class.st | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/NewTools-Core/StPharoJobManager.class.st b/src/NewTools-Core/StPharoJobManager.class.st index 806d7751..7f8533eb 100644 --- a/src/NewTools-Core/StPharoJobManager.class.st +++ b/src/NewTools-Core/StPharoJobManager.class.st @@ -63,10 +63,7 @@ StPharoJobManager class >> jobChanged: ann [ StPharoJobManager class >> jobEnd: ann [ self isHeadless ifTrue: [ ^ self ]. - self jobList jobEnd: ann. - "this is just a cleanup... because jobs may leak!" - self jobList isEmpty - ifTrue: [ self application removeProperty: #jobList ] + self jobList jobEnd: ann ] { #category : 'private' } From c228cb38acc84a40c64152b400f71b92fb7cf541 Mon Sep 17 00:00:00 2001 From: Esteban Lorenzano Date: Tue, 13 Feb 2024 10:51:08 +0100 Subject: [PATCH 2/2] disable for now --- src/NewTools-Core/StPharoJobManager.class.st | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/NewTools-Core/StPharoJobManager.class.st b/src/NewTools-Core/StPharoJobManager.class.st index 7f8533eb..a7783e13 100644 --- a/src/NewTools-Core/StPharoJobManager.class.st +++ b/src/NewTools-Core/StPharoJobManager.class.st @@ -2,7 +2,7 @@ This is a JobManager to work with the Jobs package. This manager will listen to the announcer and fire the events as it corresponds, allowing the user to interact with the joblist tool. - +This is a HACK (hopefully temporal) based on the fact that most of the processing in pharo (for the moment) is hidden deep in the model, far from the UI, and even worst, most of it happens inside the UI Thread, blocking regular processing. " Class { #name : 'StPharoJobManager', @@ -40,7 +40,7 @@ StPharoJobManager class >> enable [ { #category : 'class initialization' } StPharoJobManager class >> initialize [ - self enable + "self enable" ] { #category : 'private' }