Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Settings Browser: does not open when a custom setting is used #16399

Closed
astares opened this issue Apr 3, 2024 · 3 comments
Closed

Preview Settings Browser: does not open when a custom setting is used #16399

astares opened this issue Apr 3, 2024 · 3 comments

Comments

@astares
Copy link
Member

astares commented Apr 3, 2024

In a fresh Pharo 12 image:

  1. Create or load any tool with a custom setting ( a tool that uses the "<systemsettings>" pragma) like https://github.com/astares/Pharo-Pomodoro
Metacello new 
	repository: 'github://astares/Pharo-Pomodoro:main/src';
	baseline: 'Pomodoro';
	load
  1. Open the Preview of the new Settings Browser from the world menu

image

Looks like it tries to search for an icon in the icon map

image

Maybe a "fallback" icon should be used so at least it is possible to open this tool when no icon is provided.

@hernanmd
Copy link
Member

hernanmd commented Apr 3, 2024

Fix proposed in pharo-spec/NewTools#734

@hernanmd hernanmd self-assigned this Apr 3, 2024
@hernanmd hernanmd added this to Pharo12 Apr 3, 2024
@jecisc
Copy link
Member

jecisc commented Apr 4, 2024

Merged

@jecisc jecisc closed this as completed Apr 4, 2024
@github-project-automation github-project-automation bot moved this to Done in Pharo12 Apr 4, 2024
@astares
Copy link
Member Author

astares commented Apr 4, 2024

@hernanmd Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants