Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu item ‘Revert to selected version’ in recent versions of a method does not revert #16045

Closed
Rinzwind opened this issue Jan 28, 2024 · 7 comments
Labels
To fix before release Issure to fix before the upcoming Pharo release

Comments

@Rinzwind
Copy link
Contributor

In Pharo 12 build 1323, the context menu item ‘Revert to selected version’ in the recent versions of a method does not seem to work. The balloon text also seems wrong:

The ‘Revert’ toolbar button does work.

@Rinzwind
Copy link
Contributor Author

Also: all of the other toolbar buttons (‘Browse’, ‘References’, ‘Senders’ and ‘Implementors’) cause a MessageNotUnderstood to be signaled.

@Ducasse
Copy link
Member

Ducasse commented Jan 28, 2024

This is the price to pay when we do not write tests. :(

@bouraqadi
Copy link
Contributor

Experienced the same bug here. I think this should be fixed before releasing P12.

@guillep guillep added the To fix before release Issure to fix before the upcoming Pharo release label Feb 23, 2024
@bouraqadi
Copy link
Contributor

No suprize revert does not work. Method StVersionBrowserPresenter >> #doRevert is empty!

@bouraqadi
Copy link
Contributor

This issue actually belongs to NewTools.
Bug fixed + PR opened.

@MarcusDenker
Copy link
Member

fix merged

@Rinzwind
Copy link
Contributor Author

Thanks! I quickly tried it out using Pharo 12 build 1402. The menu item ‘Revert to selected version’ works again. But the balloon text still seems wrong. The toolbar buttons ‘Browse’, ‘References’, ‘Senders’ and ‘Implementors’ also still cause a MessageNotUnderstood to be signaled.

Perhaps this should be reopened, or should a new issue be opened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
To fix before release Issure to fix before the upcoming Pharo release
Projects
None yet
Development

No branches or pull requests

5 participants