Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance of MetacelloProjectReferenceSpec did not understand #projectPackage #15929

Closed
Ducasse opened this issue Jan 7, 2024 · 6 comments · Fixed by #15934 or #15937
Closed

Instance of MetacelloProjectReferenceSpec did not understand #projectPackage #15929

Ducasse opened this issue Jan 7, 2024 · 6 comments · Fixed by #15934 or #15937
Assignees

Comments

@Ducasse
Copy link
Member

Ducasse commented Jan 7, 2024

in pharo-spec/NewTools#652
the build is showing this MetacelloProjectReferenceSpec did not understand #projectPackage
This is probably related to the Metacello cleaning pass.

I do not know if this is something special of newtools configuration

@theseion
Copy link
Contributor

theseion commented Jan 7, 2024

A change in ad8fb7c98e0b1879771627446c5c1c5b8c9f22f9 (probably, @guillep) broke Metacello. SmalltalkCI is affected as well. Can be debugged easily by cloning https://github.com/hpi-swa/smalltalkCI and running (make sure that the current image is downloaded, there's currently a bug that will use the cached image for alpha):

./run.sh -s Pharo64-alpha --headful .smalltalk.ston
GitHub
Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others. - GitHub - hpi-swa/smalltalkCI: Framework for testing Smalltalk projects with GitHub Action...

@Ducasse
Copy link
Member Author

Ducasse commented Jan 7, 2024

Thanks. I think that we will another pass. It would have been so nice to have more tests. But we will get there.

@Ducasse
Copy link
Member Author

Ducasse commented Jan 7, 2024

I'm rechecking because in P11 I'm still sharing my repo so the latest changes were not loaded

@Ducasse
Copy link
Member Author

Ducasse commented Jan 7, 2024

So I got the same- P11 with a green bar.

@guillep
Copy link
Member

guillep commented Jan 8, 2024

Not quite yet, Smalltalk CI depends on MetacelloIgnorePackageLoaded that looked like an internal-use only class.
I'll add it back deprecated for now

@guillep
Copy link
Member

guillep commented Jan 8, 2024

The newtools build works now ^^ pharo-spec/NewTools#652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants