gtAllKeyCategoryPairs does not exist but it still called

[Ducasse]

spotterForKeysFor: aStep
	<stSpotterOrder: 15>
		
	aStep listProcessor
			title: 'Keys';
			allCandidates: [ (self gtAllKeyCategoryPairs collect: [:each | each key]) asOrderedCollection ];
			itemName: [ :aKeymap | 
				aKeymap shortcut displayString, 
				(aKeymap name ifNil: [ '' ] ifNotNil: [ ' [', aKeymap name,']' ]) ];
			candidatesLimit: 5;
			filter: StFilterSubstring

[jecisc]

I have the impression that a lot of extensions of the Spotter are never called. I removed multiple things related to Packages and Monticello calling code that just could not work a few weeks ago and if we never had a DNU this means that either we have a #on:do: or that the code is dead code.

[MarcusDenker]

I think they are part of feature of spotter that we never use: if you inspect an object, you can use spotter on that object and the subgraph of it (depending of these implemented exptensions).

[Ducasse]

let us remove it.

[hernanmd]

I found a way to reproduce this:

StSpotter openOnOrigin: KMDispatcher allInstances anyOne.

However as I don't use Spotter, I don't know if this is a valid use case.
Do you want me to reinstate the missing method or just kill it?

[Ducasse]

Let us remove the methods.

[Ducasse]

When we do not use something for more than 4 years then it does exist and the rest is dead code.

[hernanmd]

When we do not use something for more than 4 years then it does exist and the rest is dead code.

Rog that. In pharo-spec/NewTools#676

[hernanmd]

Merged in NewTools