-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#16637] - refactor: allow utf8 in email local part. #16638
[#16637] - refactor: allow utf8 in email local part. #16638
Conversation
Thank you @noone-silent |
It seems that you are focusing on internationalization of the local part, but don't you need to consider internationalizing the domain name? By the way, RFC5336 has been abolished and the revised version is RFC 6531. |
The domain part with umlauts or non ascii chars is normally not valid and needs to be transformed to ascii through punycode. There is a function in the INTL extension. Non ASCII chars in the local part is totally valid and doesn't need any transformation. |
Non-ASCII characters in the local part are still uncommon (which is why they're disabled by default even with this update, perhaps?), so when considering validation of email addresses that contain non-ASCII characters, it seems unfair to not take the domain part into consideration. |
We could implement this, but that would need the intl extension and I don't know if this is a requirement for Phalcon or if it is usable in Zephir. So if it is not a requirement, it would be a breaking change. |
I don't know if this is a breaking change or a requirement of some kind. |
Hello!
In raising this pull request, I confirm the following:
Small description of change: Allow UTF8 in local part of the email, if
allowUTF8
istrue
Thanks