Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and refactor code #16105

Merged
merged 5 commits into from
Sep 20, 2022
Merged

Improve and refactor code #16105

merged 5 commits into from
Sep 20, 2022

Conversation

Jeckerson
Copy link
Member

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

@Jeckerson Jeckerson added the 5.0 The issues we want to solve in the 5.0 release label Sep 19, 2022
@Jeckerson Jeckerson requested a review from niden September 19, 2022 23:04
@Jeckerson Jeckerson self-assigned this Sep 19, 2022
@Jeckerson Jeckerson marked this pull request as draft September 19, 2022 23:25
@Jeckerson Jeckerson marked this pull request as ready for review September 20, 2022 10:55
@niden niden added the enhancement Enhancement to the framework label Sep 20, 2022
@niden niden merged commit 9dddf58 into 5.0.x Sep 20, 2022
@niden niden deleted the code-improvements branch September 20, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees

@Jeckerson Jeckerson

Labels
5.0 The issues we want to solve in the 5.0 release enhancement Enhancement to the framework
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeckerson @niden