Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16070 numericality #16071

Merged
merged 3 commits into from
Aug 24, 2022
Merged

T16070 numericality #16071

merged 3 commits into from
Aug 24, 2022

Conversation

niden
Copy link
Member

@niden niden commented Aug 24, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Filter\Validation\Validator\Numericality to correctly detect illegal characters within string numbers

Thanks

@niden niden requested a review from Jeckerson August 24, 2022 14:05
@niden niden self-assigned this Aug 24, 2022
@niden niden linked an issue Aug 24, 2022 that may be closed by this pull request
[BUG]: Validator\Numericality If not continuous, many letters and symbols will slip through #16070
Closed
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Aug 24, 2022
@niden niden merged commit 3a2e900 into phalcon:5.0.x Aug 24, 2022
@niden niden deleted the T16070-numericality branch August 24, 2022 22:13
@niden niden mentioned this pull request Aug 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Validator\Numericality If not continuous, many letters and symbols will slip through
2 participants
@niden @Jeckerson