Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T15322 jwt inheritance #15323

Merged
merged 5 commits into from
Mar 2, 2021
Merged

T15322 jwt inheritance #15323

merged 5 commits into from
Mar 2, 2021

Conversation

niden
Copy link
Member

@niden niden commented Mar 2, 2021

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed setClaims to be protected so that the Phalcon\Security\JWT\Builder class can be properly extended.

Thanks

@niden niden linked an issue Mar 2, 2021 that may be closed by this pull request
Phalcon/Security/JWT/Builder - Can't access setClaim() through inheritance #15322
Closed
@niden niden added 4.1.1 The issues we want to solve in the 4.1.1 release bug A bug report status: medium Medium labels Mar 2, 2021
@niden niden requested a review from Jeckerson March 2, 2021 16:47
@niden
Copy link
Member Author

niden commented Mar 2, 2021

@Jeckerson have a look please

@niden niden merged commit b2ce377 into 4.1.x Mar 2, 2021
@niden niden deleted the T15322-jwt-inheritance branch March 2, 2021 18:25
@niden niden mentioned this pull request Mar 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees
No one assigned
Labels
4.1.1 The issues we want to solve in the 4.1.1 release bug A bug report status: medium Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phalcon/Security/JWT/Builder - Can't access setClaim() through inheritance
2 participants
@niden @Jeckerson