Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Acl default action to DENY #13758

Closed
niden opened this issue Jan 10, 2019 · 1 comment
Closed

Change Acl default action to DENY #13758

niden opened this issue Jan 10, 2019 · 1 comment
Assignees
@niden
Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework

Comments

@niden
Copy link
Member

niden commented Jan 10, 2019

The default access level for Acl is Acl::ALLOW.

It needs to be changed to Acl::DENY to ensure that only the developer/app allow subjects and operations vs the component itself
@niden niden added enhancement Enhancement to the framework breaks bc Functionality that breaks Backwards Compatibility labels Jan 10, 2019
@niden niden self-assigned this Jan 10, 2019
@niden niden mentioned this issue Jan 10, 2019
Merged
3 tasks
niden added a commit that referenced this issue Jan 10, 2019
@niden
Merge branch 'niden-T13758-acl-default-access-level' into 4.0.x
28ebca5 
* niden-T13758-acl-default-access-level:
  [#13758] - Added changelog entry
  [#13758] - Added test for default action in Acl
  [#13758] - Added default action to be deny
  [4.0.x] - Added match to travis for issue branches
  [4.0.x] - Code cleanup
  Revert "Revert "[4.0.x] -""
  Revert "[4.0.x] -"
  [4.0.x] -
  [4.0.x] - PHPCS fix
@niden
Copy link
Member Author

niden commented Jan 10, 2019

Implemented

@niden niden closed this as completed Jan 10, 2019
CameronHall added a commit to CameronHall/cphalcon that referenced this issue Jan 20, 2019
@CameronHall
phalcon#13758: Phalcon\Exception implements \Throwable
de63879
@CameronHall CameronHall mentioned this issue Jan 20, 2019
Merged
2 tasks
niden pushed a commit that referenced this issue Jan 23, 2019
@CameronHall @niden
#13758: Phalcon\Exception implements \Throwable (#13776)
54d725c
@niden niden added the 4.0 label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@niden