[2.1.x] Phalcon/Mvc/Model/Validator namespace

[Jurigag]

Why we keep this namespace ? Is there any way to use old validation in models ? I don't see it, validate method accepts only Phalcon\ValidationInterface.

At least we should trigger deprecated and inform that this is deprecated and Phalcon\Validation can be used only on creating of any validator.

[sergeyklay]

We declared as deprecated valdators from Phalcon/Mvc/Model/Validator namespace, but validators is there

[Jurigag]

https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/model/validator.zep construct method looks the same. I know if we will try to use code from 2.0.x validate method on 2.1.x without changes it will throw some exception or error but still if someone will create just some validator object then i think he should be informed about deprecation of it.

[sergeyklay]

Refs: #12098

[SidRoberts]

By the way, Phalcon\Mvc\Collection still uses the old model validators.

[Jurigag]

Yea, we need to mark it as deprecated, possibly add option to use both validation ways and remove old validation in 4.0.0.

Like change validate method to accept both Phalcon\Mvc\Validator\* and Phalcon\Validation, mark them as deprecated, from later versions trigger deprecated if using it(or already now ?), in 4.0.0 remove it.

Just in my opinion in 3.1.0:

• add option to use new validation(keep old one too ofc)
• add @deprecated on https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/collection.zep#L681 and https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/model/validator.zep#L29

In 3.2.0 make deprecated methods(so it will trigger_error):

• https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/collection.zep#L681
• https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/model/validator.zep#L39

[niden]

This has already been addressed