pg17 not compiling yet

[luss]

I tagged 3.0beta1 and noticed and it looks like we need some #ifdef's to compile against pg17.

125:21: note: 'create_foreignscan_path' declared here
125 | extern ForeignPath *create_foreignscan_path(PlannerInfo *root, RelOptInfo *rel,
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
126 | PathTarget *target,
| ~~~~~~~~~~~~~~~~~~~
127 | double rows, Cost startup_cost, Cost total_cost,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
128 | List *pathkeys,
| ~~~~~~~~~~~~~~~
129 | Relids required_outer,
| ~~~~~~~~~~~~~~~~~~~~~~
130 | Path *fdw_outerpath,
| ~~~~~~~~~~~~~~~~~~~~
131 | List *fdw_restrictinfo,
| ~~~~~~~~~~~~~~~~~~~~~~~
132 | List *fdw_private);
| ~~~~~~~~~~~~~~~~~
2 errors generated.
make: *** [/opt/pgbin-build/pgbin/comp20240523_0820/build/multicorn-pg17-3.0beta1-1-arm9/lib/postgresql/pgxs/src/makefiles/../../src/Makefile.global:1090: src/multicorn.bc] Error 1
[build@eqn-arm9 bld]$

[devrimgunduz]

Hi @luss ,

This fixes the builds:

d57b998

Any chance you can release a new tarball so that I can build the RPMs?

Thanks!

Regards, Devrim

[mfenniak]

Note that multicorn2 isn't currently running any tests against PG17. The test suite can be updated in flake.nix but (lightly) requires the release to be packaged in nixpkgs first.