Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_info_from_conninfo returns "host=" in host variable #22

Open
nward opened this issue Feb 12, 2019 · 1 comment
Open

get_info_from_conninfo returns "host=" in host variable #22

nward opened this issue Feb 12, 2019 · 1 comment

Comments

@nward
Copy link

nward commented Feb 12, 2019

Hi,

I am testing pgpool 4.0.2 at the moment, and note that verify_backend_node_status returns incorrect results, and decides that the replica servers are not connected:

verify_backend_node_status: primary 1 does not connect to standby 0

However, the servers are.

I have inspected the code, and I see that get_info_from_conninfo skips over "port=" but does not skip over "host=", so, the value of host is "host=", while port is simply the string of the port number.

When the comparison between the configured backend_host and host happens, this does not match - of course.

I note that get_info_from_conninfo is not used anywhere else, so I will submit at PR to resolve this by skipping over "host=".

@pengbo0328
Copy link
Collaborator

Yes. You are correct.
"host=" should be skipped like "port=".
I will commit your patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants