Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PG-142] JSDoc Documentation #6

Closed
3 of 4 tasks
pgerke opened this issue May 10, 2022 · 3 comments · Fixed by #9
Closed
3 of 4 tasks

[PG-142] JSDoc Documentation #6

pgerke opened this issue May 10, 2022 · 3 comments · Fixed by #9
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@pgerke
Copy link
Owner

pgerke commented May 10, 2022

The better part of the API is decorated with JSDoc comments. This documentation should be made available to consumers.

  • Build JSDoc documentation
  • Host on GitHub pages
  • Use a template that does not have vulnerabilities
  • Add documentation for all public entities
@pgerke pgerke added the documentation Improvements or additions to documentation label May 10, 2022
@pgerke pgerke self-assigned this May 10, 2022
@pgerke pgerke linked a pull request May 10, 2022 that will close this issue
@pgerke
Copy link
Owner Author

pgerke commented May 10, 2022

The initial version of the documentation is available at https://pgerke.github.io/freeathome-local-api-client/

@pgerke
Copy link
Owner Author

pgerke commented May 10, 2022

Unfortunately, there seems to be a vulnerability with the better-docs template that I selected... 🙈

@pgerke
Copy link
Owner Author

pgerke commented May 14, 2022

I couldn't find a JSDoc template that supported Typescript as well as the better-docs template. There are PRs aiming to resolve the vulnerability issues (SoftwareBrothers/better-docs#205 and SoftwareBrothers/better-docs#208). Keeping in mind that the vulnerabilities are development vulnerabilities and do not affect production code, I'll stick with better-docs, hoping that a new version will be released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant