Introduce feature flagging for time crate #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
requested review from
BradyBonnette,
johnrballard and
SaltyDavidselph
|
For reference, this feature flag doesn't break any user's API as the flagged impls were introduced during |
johnrballard
approved these changes
Aug 31, 2022
| PGX has optional feature flags for Rust code that do not involve configuring the version of Postgres used, | ||
| but rather extend additional support for other kinds of Rust code. These are not included by default. | ||
|
|
||
| ### "time-crate": interop with the `time` crate |
There was a problem hiding this comment.
This name works for me. Good job finding a name.
I don't think it will have much of an impact in practice, since we enable it in pgx-tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complements the deprecation process that has already begun by allowing us to make this crate an optional dependency in a future version of PGX.