Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Github Action runners for PGX #541

Merged
merged 126 commits into from
Apr 18, 2022
Merged

Updates Github Action runners for PGX #541

merged 126 commits into from
Apr 18, 2022

Conversation

BradyBonnette
Copy link
Contributor

This update includes a few things that help speed up Github Action runs and also give slightly better output for the end-user.

  • A proper balance of throughput between number of parallel jobs and execution time per job, while also making it clearer about what job is ran and what has failed
  • Uses Github Actions cache + sccache within each runner to speed up subsequent runs when only codebase code has changed
  • Includes a MacOS build to ensure that any changes to the codebase will still build on a Mac (macos-11)

@eeeebbbbrrrr
Copy link
Contributor

Just a few comments from our discussion this morning:

  • Trim down the cargo pgx init jobs to only do pg14.
  • Shorten job titles to "pgx-tests & examples", "cargo pgx init", and "MacOS build & test"

Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments on the PR itself. After those are addressed I believe this is good to merge!

@BradyBonnette BradyBonnette merged commit a6527d8 into pgcentralfoundation:develop Apr 18, 2022
@BradyBonnette BradyBonnette deleted the brady/gha-updates branch April 18, 2022 17:00
@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants