-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update copyright headers #511
Conversation
Portions Copyright 2019-2021 ZomboDB, LLC. | ||
Portions Copyright 2021-[year] Technology Concepts & Design, Inc. <[email protected]>. | ||
All rights reserved. | ||
Use of this source code is governed by the [ident] license that can be found in the LICENSE file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is obvious (literally all source code is guarded by its license) and doesn't need to be included.
.licensure.yml
Outdated
- name: ZomboDB, LLC and Technology Concepts & Design, Inc. | ||
email: [email protected] | ||
template: | | ||
Portions Copyright 2019-2021 ZomboDB, LLC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright statements are typically one line.
.licensure.yml
Outdated
template: | | ||
Portions Copyright 2019-2021 ZomboDB, LLC. | ||
Portions Copyright 2021-[year] Technology Concepts & Design, Inc. <[email protected]>. | ||
All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found previous artifacts of this statement in WebRTC's repo: https://webrtc.github.io/webrtc-org/license/software/
I did note that this may cause some confusion to some folks: PowerShell/PowerShell#2129
authors: | ||
- name: ZomboDB, LLC and Technology Concepts & Design, Inc. | ||
email: [email protected] | ||
template: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that the MIT license requires no such header for either the original or any derivative works: https://choosealicense.com/licenses/mit/
So this could be removed entirely.
.licensure.yml
Outdated
- files: any | ||
ident: MIT | ||
authors: | ||
- name: ZomboDB, LLC and Technology Concepts & Design, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the header below showing
Portions Copyright 2019-2021 ZomboDB, LLC.
Then, later:
Portions Copyright 2021-[year] Technology Concepts & Design, Inc. [email protected]."
... It seems incorrect to list ZomboDB, LLC
as a current copyright holder? Should ZomboDB, LLC
have their copyright header portion changed to include 2022
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only one that needs to be fixed, and I'll do that right now. This licensure
tool is quite terrible and I hadn't had any caffeine this morning when I pushed this.
* update copyright headers (#511) * Add pg_operator.h (#512) * Add include for pg_operator.h * Regenerate bindings * Add Copy and Clone to the time_stamp_* types (#509) * Add from impls for pg_sys -> pgx timestamp* (#510) * Remove dead --workspace flag on cargo pgx test (#520) * Pass RUSTFLAGS to rustc on schema generate (#513) * Prepare 0.4.2 (#522) * upgrade dependencies * bump version to v0.4.2 Co-authored-by: Einar <[email protected]> Co-authored-by: James Sewell <[email protected]> Co-authored-by: Ana Hobden <[email protected]>
I put this against
develop
but I think we should also merge it intomaster
. No need for a new release, of course.