Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update copyright headers #511

Merged
merged 3 commits into from
Mar 28, 2022
Merged

update copyright headers #511

merged 3 commits into from
Mar 28, 2022

Conversation

eeeebbbbrrrr
Copy link
Contributor

@eeeebbbbrrrr eeeebbbbrrrr commented Mar 26, 2022

I put this against develop but I think we should also merge it into master. No need for a new release, of course.

@eeeebbbbrrrr eeeebbbbrrrr requested a review from Hoverbear March 26, 2022 19:00
Portions Copyright 2019-2021 ZomboDB, LLC.
Portions Copyright 2021-[year] Technology Concepts & Design, Inc. <[email protected]>.
All rights reserved.
Use of this source code is governed by the [ident] license that can be found in the LICENSE file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is obvious (literally all source code is guarded by its license) and doesn't need to be included.

.licensure.yml Outdated
- name: ZomboDB, LLC and Technology Concepts & Design, Inc.
email: [email protected]
template: |
Portions Copyright 2019-2021 ZomboDB, LLC.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright statements are typically one line.

.licensure.yml Outdated
template: |
Portions Copyright 2019-2021 ZomboDB, LLC.
Portions Copyright 2021-[year] Technology Concepts & Design, Inc. <[email protected]>.
All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found previous artifacts of this statement in WebRTC's repo: https://webrtc.github.io/webrtc-org/license/software/

I did note that this may cause some confusion to some folks: PowerShell/PowerShell#2129

authors:
- name: ZomboDB, LLC and Technology Concepts & Design, Inc.
email: [email protected]
template: |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that the MIT license requires no such header for either the original or any derivative works: https://choosealicense.com/licenses/mit/

So this could be removed entirely.

.licensure.yml Outdated
- files: any
ident: MIT
authors:
- name: ZomboDB, LLC and Technology Concepts & Design, Inc.
Copy link
Contributor

@Hoverbear Hoverbear Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the header below showing

Portions Copyright 2019-2021 ZomboDB, LLC.

Then, later:

Portions Copyright 2021-[year] Technology Concepts & Design, Inc. [email protected]."

... It seems incorrect to list ZomboDB, LLC as a current copyright holder? Should ZomboDB, LLC have their copyright header portion changed to include 2022?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only one that needs to be fixed, and I'll do that right now. This licensure tool is quite terrible and I hadn't had any caffeine this morning when I pushed this.

@eeeebbbbrrrr eeeebbbbrrrr merged commit 4d3a9a7 into develop Mar 28, 2022
eeeebbbbrrrr added a commit that referenced this pull request Mar 30, 2022
* update copyright headers (#511)

* Add pg_operator.h (#512)

* Add include for pg_operator.h

* Regenerate bindings

* Add Copy and Clone to the time_stamp_* types (#509)

* Add from impls for pg_sys -> pgx timestamp* (#510)

* Remove dead --workspace flag on cargo pgx test (#520)

* Pass RUSTFLAGS to rustc on schema generate (#513)

* Prepare 0.4.2 (#522)

* upgrade dependencies

* bump version to v0.4.2

Co-authored-by: Einar <[email protected]>
Co-authored-by: James Sewell <[email protected]>
Co-authored-by: Ana Hobden <[email protected]>
@eeeebbbbrrrr eeeebbbbrrrr mentioned this pull request Apr 19, 2022
@eeeebbbbrrrr eeeebbbbrrrr deleted the update-copyright-headers branch June 20, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants