feat: add aggregate example #187
Conversation
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
|
Based on some feedback from @eeeebbbbrrrr I migrated this to using |
| .DS_Store | ||
| .idea/ | ||
| /target | ||
| *.iml |
There was a problem hiding this comment.
out of interest, what's an .iml file?
There was a problem hiding this comment.
It’s a CLion project file
| @@ -0,0 +1,5 @@ | |||
| comment = 'aggregate: Created by pgx' | |||
There was a problem hiding this comment.
Thought: perhaps we should have a URL that people can visit so they know what pgx is i they encounter it in their logs?
There was a problem hiding this comment.
I suggest opening an issue if you feel passionate about this in a general case! I think most users would set this to what their Cargo.toml description is!
pgx-examples/aggregate/src/lib.rs
Outdated
| pg_module_magic!(); | ||
|
|
||
|
|
||
| use serde::{Deserialize, Serialize}; |
There was a problem hiding this comment.
Is this where we want this import?
There was a problem hiding this comment.
I keep forgetting we don't run rustfmt on CI...
|
|
||
| let mut split = input.to_bytes().split(|b| *b == b','); | ||
| let sum = split.next().map(|value| | ||
| i32::from_str(unsafe { std::str::from_utf8_unchecked(value) }).expect("invalid i32") |
There was a problem hiding this comment.
In the error message, should we match the Postgres type name?
There was a problem hiding this comment.
I'm not sure this is important, it's an fairly small example. :)
pgx-examples/aggregate/src/lib.rs
Outdated
| buffer.push_str(&self.sum.to_string()); | ||
| buffer.push(','); | ||
| buffer.push_str(&self.n.to_string()); |
There was a problem hiding this comment.
Personal preference only. Slightly easier to skim read.
| buffer.push_str(&self.sum.to_string()); | |
| buffer.push(','); | |
| buffer.push_str(&self.n.to_string()); | |
| buffer.push_str(&format!("{},{}"), self.sum, self.n); |
There was a problem hiding this comment.
That would be doing allocations in what might be a hot path for Postgres. The idea of StringBuffer is to save that.
There was a problem hiding this comment.
One of the reasons I considered using format was that it would only involve 1 allocation rather than 2 (each call to .to_string()).
Signed-off-by: Ana Hobden <[email protected]>
Signed-off-by: Ana Hobden <[email protected]>
Adds a aggregate example as demonstrated by @laysakura in #102 . Thanks!!!