Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting cargo binstall? #681

Open
workingjubilee opened this issue Sep 10, 2022 · 2 comments
Open

Supporting cargo binstall? #681

workingjubilee opened this issue Sep 10, 2022 · 2 comments
Labels
deps About dependency management enhancement New feature or request

Comments

@workingjubilee
Copy link
Member

workingjubilee commented Sep 10, 2022

At least one user mentioned they like to use cargo binstall, and it seems sensible enough, but that user also encountered mysterious problems when updating a project which leads me to suspect we may need to tweak some details in our Cargo.toml metadata in order to fully support binstalls.

PGRX and thus cargo pgrx has some security concerns given the nature of the projects it builds, but our CI is secure enough that cargo binstall piggybacking off of it seems like a fine way of delivering a binary for common devtool usage. High-security operations which trust other networks less will want to build from our Rust source after obtaining a trusted Rust compiler, naturally, but our README and the like is effectively talking to the average user who hasn't brought in any other considerations yet, which includes a lot of Jackie Devvers.

But, honestly, given that our next action is to recommend the user fetch and build from source all versions of Postgres that we support, uh... well, the "resource constrained devices" reasoning for supporting binstalls doesn't apply as much.

Important detail: We would also like our users to use the lockfile we actually checked in, so we would want that to also be done by the binstall build. If that can be arranged, that itself is actually a reason to support them.

@workingjubilee workingjubilee added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested deps About dependency management wontfix This will not be worked on and removed question Further information is requested good first issue Good for newcomers help wanted Extra attention is needed labels Sep 10, 2022
@workingjubilee
Copy link
Member Author

Okay, I don't think this is actually viable given issues in cargo-pgx mentioned in #687. We might be able to fix that so cargo-pgx is independent eventually, but not today.

@workingjubilee workingjubilee closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2022
@usamoi
Copy link
Contributor

usamoi commented Feb 19, 2024

Will we reopen this issue since we have removed dlopen?

@workingjubilee workingjubilee removed the wontfix This will not be worked on label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps About dependency management enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants