Build wheels for PyPy #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This skips building the C extension and only uses the pure Python version when built on PyPy. This is probably the right thing to do on PyPy anyway, since PyPy needs to use a compatibility layer for the C extension, and that slows things down considerably. Running the benchmark suite, the C extension is consistently 10x slower than the pure Python implementation on PyPy.
This skips building the C extension and only uses the pure Python version when built on PyPy. This is probably the right thing to do on PyPy anyway, since PyPy needs to use a compatibility layer for the C extension, and that slows things down considerably. Running the benchmark suite, the C extension is consistently 10x slower than the pure Python implementation on PyPy.
This is a tricky situation, because the PyPy wheel is special — it does not contain the C extension. We do not want this being picked up by anything except pypy. Unfortunately, after pip version 19.3.1 (and until at least version 20.1.1), pip will not pick up the `pp3-none-any.whl` tag (see https://github.com/pypa/pip/issues/8347 ), so pypy users with a recent version of pip will get the sdist (which is our only alternative really anyway). We'll ship these wheels anyway, since this seems to be an issue with pip, and this is indeed the proper tag for PyPy 3 wheels.
|
I don't think this is going to happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had originally added this to #74, but then I found out that
packagingdeliberately removed support for interpreter-specific abi-agnostic wheels, and inpip >= 20,pipadoptedpackaging.tags, meaning the latest version ofpipwon't pick up these wheels in the first place.I've opened pypa/packaging#311 to try to get these supported again, but the outcome is still uncertain, so I've split this off into its own separate PR so as not to block the release of a version of the backport that supports PyPy on something as simple as uploading wheels with the right file name — since the PyPy version is distinguished by not using the C extension, being unable to deliver wheels for it is not as bad as it could be.