Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull_gemm() may miss some unique species names #167

Open
brianlangseth-NOAA opened this issue Dec 31, 2024 · 0 comments
Open

pull_gemm() may miss some unique species names #167

brianlangseth-NOAA opened this issue Dec 31, 2024 · 0 comments

Comments

@brianlangseth-NOAA
Copy link
Contributor

brianlangseth-NOAA commented Dec 31, 2024

PROBLEM

Im using pull_gemm() to get the newest gemm report (2023). The function works and output is generated and saved. However, Im getting 14 observations of "Quillback rockfish" totalling ~ 0.5 mt of total_discard_and_landings_mt

The gemm from the 2021 assessment has 196 observations totaling ~ 300 mt of Catch..Landings.and.Discards.

If I go to the gemm website and navigate to the Data Warehouse and pull the csv for the 2023 gemm product and filter to quillback, I see 293 records with ~ 415 mt of total_discard_and_landings_mt

Thus, it appears the pull_gemm() function is missing something.

POSSIBLE SOLUTION

After going through the code, I see that there are three quillback like species names in the gemm.
Quillback Rockfish
Quillback Rockfish (California only)
Quillback Rockfish (Washington/Oregon)

Taking all of these gives numbers that I would expect

It seems like a similar issue exists for kelp greenling where there are location parentheticals in the name (e.g. Kelp greenling (California), and Kelp greenling (Coast)). While right now there are very few species were the common name is unusual, adding a grep check where the function outputs a message to the user that other commons name exist that may match their entry could be a way to resolve this.

This could look like

"There are species with a similar name to your entry, consider revising your common_name entry to include these"
Quilllback Rockfish (California)
Quillback Rockfish (Washington/Oregon)

OTHER POSSIBLE SOLUTION

Ignore this and leave it up to the user to ensure they captured all entries for their species. Right now it appears that only kelp greenling and quillback rockfish are troublesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant