Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pkg_resources.build_zipmanifest monkeypatching #91

Closed
wickman opened this issue Apr 17, 2015 · 3 comments
Closed

Remove pkg_resources.build_zipmanifest monkeypatching #91

wickman opened this issue Apr 17, 2015 · 3 comments
Assignees
@kwlzn

Comments

@wickman
Copy link
Contributor

wickman commented Apr 17, 2015

This may involve increasing the minimum setuptools version. Another alternative is vendoring setuptools.
@dan-blanchard
Copy link
Contributor

From pypa/setuptools#154, it appears the reason for the monkeypatching was fixed in setuptools 5.4, so setting the minimum version to at least that should do the trick.

@kwlzn kwlzn mentioned this issue Nov 30, 2016
Merged
@kwlzn
Copy link
Contributor

kwlzn commented Nov 30, 2016

sgtm. reviewable here: #322

@kwlzn
Copy link
Contributor

kwlzn commented Nov 30, 2016

btw, it looks like from setuptools 5.4->5.6 you have to set the PKG_RESOURCES_CACHE_ZIP_MANIFESTS environment variable to get this behavior - and it's on by default after 5.7: https://pypi.python.org/pypi/setuptools/5.7#id1

will bump the minimum version in the PR to 5.7 based on this.

@kwlzn kwlzn self-assigned this Nov 30, 2016
@kwlzn kwlzn closed this as completed in #322 Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwlzn kwlzn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wickman @dan-blanchard @kwlzn