Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Regular Expressions #75

Closed
dluftspring opened this issue Nov 9, 2022 · 1 comment · Fixed by #77
Closed

Support Regular Expressions #75

dluftspring opened this issue Nov 9, 2022 · 1 comment · Fixed by #77

Comments

@dluftspring
Copy link
Contributor

It would be great to be able to match comment bodies based on regex whereas right now this only works with containment. From briefly looking at the source code I think this might work by replacing references to string.includes with string.match. Happy to try and contribute this feature if there is interest.

@peter-evans
Copy link
Owner

Hi @dluftspring

I would be interested in supporting this feature, but I would be concerned about making a breaking behaviour change if we replaced includes with match. What I would prefer to do instead is add a new action input called body-regex, and leave body-includes untouched. The new input can be added to this function.

Feel free to take a shot at it if you like. I'm going to be away for about 2 weeks now, but if you send a PR I'll review it when I'm back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants