Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks fire twice when changing an "A" record #137

Closed
rallakwash opened this issue Jan 9, 2024 · 5 comments · Fixed by #189
Closed

Webhooks fire twice when changing an "A" record #137

rallakwash opened this issue Jan 9, 2024 · 5 comments · Fixed by #189
Assignees
Labels
bug Something isn't working

Comments

@rallakwash
Copy link

Versions
NetBox Version: 3.7.0
NetBox DNS Version: 0.21.13
Python Version: 3.11.2

Describe the bug

When changing a DNS A record, webhooks fire twice, with the same content.
The only difference is in the timestamp, about 20-30 ms.

Creating, or deleting the A record doesn't cause this issue, neither does changing any other record type.

To Reproduce
Steps to reproduce the behavior:

Change an A record, doesn't matter which field.
On the webhook listener change of the A record happens twice, while the managed PTR record only once.

image

@peteeckel
Copy link
Owner

This is a duplicate of #89 and mainly a NetBox issue. I'm working on it, but it will take some time.

@peteeckel peteeckel added the duplicate This issue or pull request already exists label Jan 9, 2024
@rallakwash
Copy link
Author

Thanks for the heads up, and looking at it.

@peteeckel
Copy link
Owner

There is now a NetBox issue for the underlying problem. Sorry this was taking so long, but it's really difficult to reproduce and took some time only for creating a reference environment for the core project to test.

@peteeckel
Copy link
Owner

This is a duplicate of #89 and mainly a NetBox issue. I'm working on it, but it will take some time.

As it turned out, it isn't ... it's a different issue, though it looked very similar until I understood the mechanics of #89.

The good news: It can be fixed without any changes to NetBox, this bug is my own :-)

@peteeckel peteeckel reopened this Feb 29, 2024
@peteeckel peteeckel self-assigned this Feb 29, 2024
@peteeckel peteeckel added bug Something isn't working and removed duplicate This issue or pull request already exists labels Feb 29, 2024
@rallakwash
Copy link
Author

Thanks for checking it. Tested it today, and seems to be working fine.
Thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants