Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for should.not_be #38

Merged
merged 1 commit into from
Dec 24, 2012
Merged

Support for should.not_be #38

merged 1 commit into from
Dec 24, 2012

Conversation

stack72
Copy link

@stack72 stack72 commented Dec 22, 2012

This was a simple addition of the types.ps1xml to add support for not_be. This was a requirement of mine when writing some scripts to work out a file location

…this, an additional test was added to the calculator to make sure that the sum was not a specific number.
scottmuc added a commit that referenced this pull request Dec 24, 2012
Support for should.not_be
@scottmuc scottmuc merged commit 1b6495a into pester:master Dec 24, 2012
@scottmuc
Copy link
Contributor

Thanks! I'll bump the version number and get this released.

@stack72
Copy link
Author

stack72 commented Dec 24, 2012

Thanks - ill add support for other methods like should.not_match, should.be_empty etc over the coming days

@scottmuc
Copy link
Contributor

I'd hold off on further object extensions. It's going to be deprecated in favour of pipeline style assertions. This is because the object extensions have been causing lots of issues for people. Plus, editing that xml doc is a real ugly way to essentially create extension methods. It was just the first thing I found at the time.

@stack72
Copy link
Author

stack72 commented Dec 24, 2012

makes sense - i'll hold tight for now. Thanks for letting me know

On Mon, Dec 24, 2012 at 11:42 AM, Scott Muc [email protected]:

I'd hold off on further object extensions. It's going to be deprecated in
favour of pipeline style assertions. This is because the object extensions
have been causing lots of issues for people. Plus, editing that xml doc is
a real ugly way to essentially create extension methods. It was just the
first thing I found at the time.


Reply to this email directly or view it on GitHubhttps://github.com//pull/38#issuecomment-11659192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants