Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NuGet package to be build with module in root #254

Merged
merged 3 commits into from
Feb 3, 2015
Merged

Allow NuGet package to be build with module in root #254

merged 3 commits into from
Feb 3, 2015

Conversation

gpduck
Copy link
Contributor

@gpduck gpduck commented Jan 15, 2015

PowerShellGet packages are currently built expecting the module to be in the root of the NuGet package, so this change allows the build script to specify a custom base for the target in the NuSpec so it can build either Chocolatey or PowerShellGet style packages.

I've left the default behavior to match the current folder structure, but a PowerShellGet module can be built using:

Invoke-PSake .\build.psake.ps1 -properties @{targetBase = "" }

@dlwyatt
Copy link
Member

dlwyatt commented Jan 15, 2015

What does this gain us? PowerShellGet takes care of its own NuGet packaging behind the scenes when you run Publish-Module; I'm not aware of a scenario where we have to do that ourselves.

@gpduck
Copy link
Contributor Author

gpduck commented Jan 15, 2015

Flexibility? I'm actually trying to setup my own builds internally at work
but I can't use the project's psake script because I need my output in the
other format. I was trying to use PowerShellGet as a reason that it would
apply to people outside my company.

@nohwnd
Copy link
Member

nohwnd commented Jan 15, 2015

@gpduck @dlwyatt currently we push to NuGet, Chocolatey and PowerShellGallery and as far as I know all the packages work just fine. But if this works without changing the configuration of the build server I see no problem merging it.

@dlwyatt dlwyatt merged commit 24768cd into pester:master Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants