Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information on the passthru code coverage property #1190

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

Thilas
Copy link
Contributor

@Thilas Thilas commented Dec 29, 2018

Per #727, I'm adding a few informations on the code coverage property returned by Invoke-Pester when using -PassThru parameter:

  • StartLine & EndLine
  • StartColumn & EndColumn
  • HitCount

I kept though existing Line but it's just returning the same value as StartLine. This is only for compatibility purpose and I was wondering if this is necessary here?

I also removed AllCommands that was introduced by #920 but to me it's redundant with what is already provided (i.e. HitCommands and MissedCommands).

@nohwnd, any thoughts? Could you review? Thanks.

@nohwnd
Copy link
Member

nohwnd commented Jan 3, 2019

@Thilas Not sure if the Line is necessary but I would keep it to avoid breaking change. The AllCommands was not released so it's okay that you replaced it. Thanks!

@nohwnd nohwnd merged commit 6231bea into pester:master Jan 3, 2019
@Thilas Thilas deleted the support-line-range branch January 3, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants