Fix features and scenario names do not display when PesterResult is printed to the console #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourpastmidnight
force-pushed
the
fix-features-and-scenario-names-do-not-display-in-test-report
branch
from
8a9fb14 to
58286cd
Compare
This commit adds a types.ps1xml file to add an "override" of the ToString method as a ScriptMethod to Gherkin.Ast.Feature objects. This will allow the feature names to be displayed when using -PassThru with Invoke-Gherkin and printing the PesterResult object to the console.
When enumerating the Gherkin scenarios, if there are scenario example tables, the scenario name is augmented to append a newline and then the text 'Examples:' followed by the name of the example table (if provided). This change, instead, appends 'Examples: ' to the scenario name to provide a space between 'Examples:' and the name of the examples table.
This commit updates the Gherkin.types.ps1xml file to add an "override" of the ToString method as a ScriptMethod to Gherkin.Ast.Scenario objects. This will allow the scenario names to be displayed when using -PassThru with Invoke-Gherkin and printing the PesterResult object to the console.
fourpastmidnight
force-pushed
the
fix-features-and-scenario-names-do-not-display-in-test-report
branch
from
58286cd to
5d3e27c
Compare
fourpastmidnight
deleted the
fix-features-and-scenario-names-do-not-display-in-test-report
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. General summary of the pull request
I used the
-PassThruparameter ofInvoke-Gherkinand discovered that feature names simply displayed asGherkin.Ast.Feature, and likewise, scenario names displayed asGherkin.Ast.Scenario. This isn't helpful. So this pull request adds the fileGherkin.types.ps1xmlwhich adds "overrides" of the ToString method as ScriptMethod methods to theGherkin.Ast.FeatureandGherkin.Ast.Scenarioobjects.This fixes #1136